Skip to content

Commit

Permalink
[InAppMessaging] Fix #12882 (#12910)
Browse files Browse the repository at this point in the history
  • Loading branch information
ncooke3 authored May 7, 2024
1 parent b414bfc commit ab94a58
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions FirebaseInAppMessaging/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Unreleased
- [fixed] Fixed crash at app start that affected SwiftPM users and CocoaPods
users using static frameworks (#12882).

# 10.25.0
- [changed] Removed usages of user defaults API to eliminate required reason
impact.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,12 @@ + (NSBundle *)getViewResourceBundle {
[NSBundle mainBundle],
// Dynamically linked.
[NSBundle bundleForClass:myClass],
#if FIREBASE_BUILD_ZIP_FILE
// Embedded static framework (zip distribution).
[NSBundle bundleWithURL:[NSBundle.mainBundle.bundleURL

This comment has been minimized.

Copy link
@paulb777

paulb777 May 8, 2024

Member

It might be more robust for various build systems, to check for non-nil and then append to the array.

URLByAppendingPathComponent:
@"Frameworks/FirebaseInAppMessaging.framework"]]
#endif // FIREBASE_BUILD_ZIP_FILE
]) {
bundleURL = [containingBundle URLForResource:bundledResource withExtension:@"bundle"];
if (bundleURL != nil) break;
Expand Down

1 comment on commit ab94a58

@rromanchuk
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ncooke3 🍻

Please sign in to comment.