Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
paulb777 committed Oct 1, 2024
1 parent 47bfe02 commit c951434
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 25 deletions.
1 change: 1 addition & 0 deletions FirebaseAppDistribution/Sources/FIRFADLogger.m
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

#import "FirebaseAppDistribution/Sources/FIRFADLogger.h"
#import "FirebaseCore/Extension/FIRLogger.h"
#import "FirebaseCore/Sources/Public/FirebaseCore/FIRLoggerLevel.h"

FIRLoggerService kFIRLoggerAppDistribution = @"[FirebaseAppDistribution]";

Expand Down
3 changes: 3 additions & 0 deletions FirebaseCore/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Firebase 11.4.0
- [fixed] Fixed issue building documentation with some Firebase products. (#13756)

# Firebase 11.0.0
- [changed] **Breaking change**: Firebase's minimum supported versions have
updated for the following platforms:
Expand Down
2 changes: 1 addition & 1 deletion FirebaseCore/Sources/FIROptionsInternal.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

#import <FirebaseCore/FIROptions.h>
#import "FirebaseCore/Sources/Public/FirebaseCore/FIROptions.h"

/**
* Keys for the strings in the plist file.
Expand Down
33 changes: 9 additions & 24 deletions FirebaseDynamicLinks/Sources/FIRDynamicLinks.m
Original file line number Diff line number Diff line change
Expand Up @@ -166,30 +166,15 @@ - (void)configureDynamicLinks:(FIRApp *)app {
userInfo:errorDict];
}
if (error) {
NSString *message = nil;
if (options.usingOptionsFromDefaultPlist) {
// Configured using plist file
message = [NSString
stringWithFormat:
@"Firebase Dynamic Links has stopped your project "
@"because there are missing or incorrect values provided in %@.%@ that may "
@"prevent your app from behaving as expected:\n\n"
@"Error: %@\n\n"
@"Please fix these issues to ensure that Firebase is correctly configured in "
@"your project.",
kServiceInfoFileName, kServiceInfoFileType, error.localizedFailureReason];
} else {
// Configured manually
message = [NSString
stringWithFormat:
@"Firebase Dynamic Links has stopped your project "
@"because there are incorrect values provided in Firebase's configuration "
@"options that may prevent your app from behaving as expected:\n\n"
@"Error: %@\n\n"
@"Please fix these issues to ensure that Firebase is correctly configured in "
@"your project.",
error.localizedFailureReason];
}
NSString *message =
[NSString stringWithFormat:
@"Firebase Dynamic Links has stopped your project "
@"because there are incorrect values provided in Firebase's configuration "
@"options that may prevent your app from behaving as expected:\n\n"
@"Error: %@\n\n"
@"Please fix these issues to ensure that Firebase is correctly configured in "
@"your project.",
error.localizedFailureReason];
[NSException raise:kFirebaseDurableDeepLinkErrorDomain format:@"%@", message];
}
[self checkForCustomDomainEntriesInInfoPlist];
Expand Down

0 comments on commit c951434

Please sign in to comment.