[App Check] Replace token refresh NSNotifications with delegate
#11524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
paulb777
reviewed
Jul 10, 2023
| @@ -48,6 +37,7 @@ NS_SWIFT_NAME(InternalAppCheck) | |||
| - (instancetype)initWithInstanceName:(NSString *)instanceName | |||
| appCheckProvider:(id<GACAppCheckProvider>)appCheckProvider | |||
| settings:(id<GACAppCheckSettingsProtocol>)settings | |||
| tokenDelegate:(id<GACAppCheckTokenDelegate>)tokenDelegate | |||
There was a problem hiding this comment.
Why isn't there a corresponding change to FirebaseAppCheck?
There was a problem hiding this comment.
I haven't finished turning FIRAppCheck into a shim yet and that's the only class in Firebase App Check that would be impacted by this change. (The refactor became too large when I tried to do this all in one.)
paulb777
approved these changes
Jul 10, 2023
andrewheard
added a commit
that referenced
this pull request
Jul 20, 2023
…1524) Replaced token refresh notifications via `NSNotificationCenter` with `GACAppCheckTokenDelegate` in the internal App Check SDK. Firebase App Check (shim SDK) can continue to support the existing `NSNotification`s by providing a `GACAppCheckTokenDelegate` that posts notifications in its `tokenDidUpdate:instanceName:` method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced token refresh notifications via
NSNotificationCenterwithGACAppCheckTokenDelegatein the internal App Check SDK.Firebase App Check (shim SDK) can continue to support the existing
NSNotifications by providing aGACAppCheckTokenDelegatethat posts notifications in itstokenDidUpdate:instanceName:method.#no-changelog