Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crashlytics][CocoaPods] Fix preserve_paths of CrashlyticsInputFiles.xcfilelist #11540

Closed
wants to merge 1 commit into from
Closed

[Crashlytics][CocoaPods] Fix preserve_paths of CrashlyticsInputFiles.xcfilelist #11540

wants to merge 1 commit into from

Conversation

ikesyo
Copy link

@ikesyo ikesyo commented Jul 13, 2023 •
edited
Loading

In 10.12.0, CrashlyticsInputFiles.xcfilelist is not correctly included in CocoaPods installation due to specifying wrong path.

image

ref:

@ikesyo
[Crashlytics][CocoaPods] Fix preserve_paths of `CrashlyticsInputFiles…
2e61668 
….xcfilelist`

In 10.12.0, `CrashlyticsInputFiles.xcfilelist` is not correctly included in CocoaPods installation due to specifying wrong path.
@paulb777 paulb777 requested a review from samedson July 13, 2023 14:01
@ikesyo
Copy link
Author

ikesyo commented Sep 8, 2023 •
edited
Loading

@samedson Could you please review this? CocoaPods users can't use the xcfilelist due to this.

@ikesyo
Copy link
Author

ikesyo commented Nov 7, 2023

ping @paulb777 @samedson

@paulb777
Copy link
Member

@ikesyo Sorry about the delay here.

I'm not able to reproduce the issue. I see the following after a pod install:

 $ ls Pods/FirebaseCrashlytics/
Crashlytics				Interop
CrashlyticsInputFiles.xcfilelist	README.md
FirebaseCore				run
FirebaseInstallations			upload-symbols

Note the prepare command in the podspec that moves CrashlyticsInputFiles.xcfilelist along with run and upload-symbols.

@paulb777
Copy link
Member

paulb777 commented Dec 9, 2023

Going to close it here. We can reopen with new information.

@paulb777 paulb777 closed this Dec 9, 2023
@ikesyo ikesyo deleted the patch-1 branch December 10, 2023 04:54
@firebase firebase locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samedson samedson Awaiting requested review from samedson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikesyo @paulb777