Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more examples to Firebase Analytics Swift SDK readme #11583

Merged
merged 9 commits into from
Jul 24, 2023
Merged

Added more examples to Firebase Analytics Swift SDK readme #11583

merged 9 commits into from
Jul 24, 2023

Conversation

Skizzy-create
Copy link
Contributor

Created custom event logging API and manual screen view event logging API significantly reduces the amount of code required for event logging:

Before: We had separate event logging codes for both the button click and screen view events, resulting in redundant lines of code.
After: With the custom event logging API and manual screen view event logging API, we have reduced the event logging code to a few lines, improving code efficiency and readability.
By using these APIs, you can easily log events and screen views throughout the app with concise and reusable code, making it more efficient and maintainable.

created an example that demonstrates how the custom event logging API and manual screen view event logging API can make the code more efficient and reduce the number of lines required for event logging.
Added more examples for Firebase Analytics Swift SDK in readme.md
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had one small nit. Thanks!

FirebaseAnalyticsSwift/README.md Outdated Show resolved Hide resolved
removed all the LogCustomEvent's wrapper
updated the end description , the before and after section of my code
@Skizzy-create
Copy link
Contributor Author

@paulb777 sir can we connect on Linkedin? Stange place to ask but i don't know how else to reach you

@Skizzy-create
Copy link
Contributor Author

also if there are any other changes let me know

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @Skizzy-create

You can reach me by email at paulbeusterien at google.com

@paulb777 paulb777 merged commit 5bcc4fe into firebase:master Jul 24, 2023
25 checks passed
@firebase firebase locked and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants