Fix crash building a module map for a product with an iOS-only Interop dependency #11620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ncooke3
approved these changes
Jul 27, 2023
paulb777
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While header-only internal Interop pods for binary distributions don't need to be built for Objective-C internal dependencies, the included module dependencies are needed for internal Swift implementations like FirebaseStorage and FirebaseFunctions.
However, the module map calculation uses platform-agnostic dependencies for setting up a
Podfilefor itspod install. This has the side effect of causing a crash when building the iOS-only ReCaptchaInterop.That issue should become moot if we address #8945 and switch to dynamic libraries along with
xcodebuildgenerated modulemaps for Firebase 11.