Implement FIRAppCheck as a shim of GACAppCheck

[andrewheard]

• Implemented FIRAppCheck.m as a shim of GACAppCheck
• Removed classes that were only needed by FIRAppCheck.m
• Added the optional method getLimitedUseTokenWithCompletion: to FIRAppCheckProvider protocol
  • This extends the implementation of Add generation of limited-use tokens with a TTL of 5 mins google/app-check#11 to Firebase App Check

#no-changelog

[github-actions]

Apple API Diff Report

Commit: f514dac
Last updated: Fri Sep 22 09:17 PDT 2023
View workflow logs & download artifacts

---

FirebaseAppCheck

Protocols

FIRAppCheckProvider

[ADDED] -getLimitedUseTokenWithCompletion:

Swift:
+  optional func getLimitedUseToken () async throws -> FIRAppCheckToken
Objective-C:
+  - ( void ) getLimitedUseTokenWithCompletion : ( nonnull void ( ^ )( FIRAppCheckToken * _Nullable , NSError * _Nullable )) handler ;

---

[andrewheard]

This test and testInteropGetTokenForcingRefresh_Success have been flaky (both locally and on CI). My hypothesis is that this is due to the inverted tokenNotification expectation which must wait the full duration of the timeout (since it's testing that a notification was not posted).

I've split these into two waits since we want to ensure that the tokenForcingRefresh completion handler is invoked and then give a little time to ensure that no notification is posted after. Will see if this addresses the flakiness.

[andrewheard]

Didn't resolve the issue. Replaced tokenUpdateNotificationWithExpectedToken:isInverted: with a new tokenUpdateNotificationNotPosted to handle the isInverted = YES case.

[morganchen12]

Can you disable xcpretty for just these tests and spit the full xcodebuild logs into GHA? It's short enough that it's probably fine and it may contain a more complete failure reason. Right now it just says test failed but doesn't say why.

[andrewheard]

Done (and added back now). Thanks for the debugging help!

[morganchen12]

LGTM

[morganchen12]

Leaving a note here for record keeping: These tests were removed because they enqueue async token fetch tasks that are run when other tests use waitForExpectations, causing test failures in other test targets. They can be reinstated if necessary, but have been replaced with E2E tests.