Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sessions] Migrate to GoogleUtilities's storage container #12752

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 11, 2024

No description provided.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ncooke3 ncooke3 marked this pull request as ready for review April 11, 2024 17:20
@ncooke3 ncooke3 requested a review from paulb777 April 11, 2024 17:38
FirebaseSessions.podspec Outdated Show resolved Hide resolved
@ncooke3
Copy link
Member Author

ncooke3 commented Apr 11, 2024

Will do a separate changelog PR for all of the products this migration applies to.

@ncooke3 ncooke3 merged commit 16f64bf into main Apr 11, 2024
83 of 84 checks passed
@ncooke3 ncooke3 deleted the nc/sessions-user-defaults branch April 11, 2024 19:07
@ncooke3
Copy link
Member Author

ncooke3 commented Apr 11, 2024

cc: @themiswang @visumickey Feel free to leave comments and I'll address in a follow-up PR.

@themiswang
Copy link
Contributor

cc: @themiswang @visumickey Feel free to leave comments and I'll address in a follow-up PR.

Thank you for fixing it Nick! LGTM and just a nit comment.

@visumickey
Copy link
Contributor

The changes look good to me. But similar to the performance situation, the configs are cached in NSUserDefaults and this change could impact that. Luckily there are no config changes that are happening for sessions that makes this change safer. So, LGTM.

@firebase firebase locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants