Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos #12760

Merged
merged 6 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/notices_generation/app.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
begin
OptionParser.new do |opts|
opts.banner = "Usage: app.rb [options]"
opts.on('-p', '--pods PODS', 'Pods seperated by space or comma.') { |v| @options[:pods] = v.split(/[ ,]/) }
opts.on('-p', '--pods PODS', 'Pods separated by space or comma.') { |v| @options[:pods] = v.split(/[ ,]/) }
opts.on('-s', '--sources SOURCES', 'Sources of Pods') { |v| @options[:sources] = v.split(/[ ,]/) }
opts.on('-m', '--min_ios_version MIN_IOS_VERSION', 'Minimum iOS version') { |v| @options[:min_ios_version] = v }
opts.on('-n', '--notices_path OUTPUT_PATH', 'The output path of NOTICES') { |v| @options[:output_path] = v }
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ viewing the [documentation][xcode-debugging].
### Testing

Tests are an essential part to building Firebase. Many of the tests
for Firebase run as part of our continous integration (CI) setup with
for Firebase run as part of our continuous integration (CI) setup with
[GitHub Actions].

* _Fixing a bug?_ Add a test to catch potential regressions in
Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/Crashlytics/Components/FIRCLSApplication.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ typedef NS_ENUM(NSInteger, FIRCLSApplicationInstallationSourceType) {
};

/**
* Returns the application bundle identifier with occurences of "/" replaced by "_"
* Returns the application bundle identifier with occurrences of "/" replaced by "_"
*/
NSString* FIRCLSApplicationGetBundleIdentifier(void);

Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/Crashlytics/Components/FIRCLSContext.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

// The purpose of the crash context is to hold values that absolutely must be read and/or written at
// crash time. For robustness against memory corruption, they are protected with guard pages.
// Further, the context is seperated into read-only and read-write sections.
// Further, the context is separated into read-only and read-write sections.

__BEGIN_DECLS

Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/Crashlytics/Components/FIRCLSProcess.c
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ static bool FIRCLSProcessGetThreadState(FIRCLSProcess *process,
return true;
}

// Here's a wild trick: emulate what thread_get_state would do. It apppears that
// Here's a wild trick: emulate what thread_get_state would do. It appears that
// we cannot reliably unwind out of thread_get_state. So, instead of trying, setup
// a thread context that resembles what the real thing would look like
if (FIRCLSProcessIsCurrentThread(process, thread)) {
Expand Down
4 changes: 2 additions & 2 deletions Crashlytics/Crashlytics/Handlers/FIRCLSMachException.c
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ static exception_mask_t FIRCLSMachExceptionMask(void) {
// is a confirmed kernel bug. Lacking access to EXC_CRASH means we must use signal handlers to
// cover all types of crashes.
// EXC_GUARD is relatively new, and isn't available on all OS versions. You have to be careful,
// because you cannot successfully register hanlders if there are any unrecognized masks. We've
// because you cannot successfully register handlers if there are any unrecognized masks. We've
// dropped support for old OS versions that didn't have EXC_GUARD (iOS 5 and below, macOS 10.6 and
// below) so we always add it now

Expand Down Expand Up @@ -192,7 +192,7 @@ static bool FIRCLSMachExceptionReadMessage(FIRCLSMachExceptionReadContext* conte
r = mach_msg(&message->head, MACH_RCV_MSG | MACH_RCV_LARGE, 0, sizeof(MachExceptionMessage),
context->port, MACH_MSG_TIMEOUT_NONE, MACH_PORT_NULL);
if (r != MACH_MSG_SUCCESS) {
FIRCLSSDKLog("Error receving mach_msg (%d)\n", r);
FIRCLSSDKLog("Error receiving mach_msg (%d)\n", r);
return false;
}

Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/Crashlytics/Handlers/FIRCLSSignal.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ static void FIRCLSSignalInstallHandlers(FIRCLSSignalReadContext *roContext) {
action.sa_sigaction = FIRCLSSignalHandler;
// SA_RESETHAND seems like it would be great, but it doesn't appear to
// work correctly. After taking a signal, causing another identical signal in
// the handler will *not* cause the default handler to be invokved (which should
// the handler will *not* cause the default handler to be involved (which should
// terminate the process). I've found some evidence that others have seen this
// behavior on MAC OS X.
action.sa_flags = SA_SIGINFO | SA_ONSTACK;
Expand Down
4 changes: 2 additions & 2 deletions Crashlytics/Crashlytics/Helpers/FIRCLSAllocate.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ FIRCLSAllocatorRef FIRCLSAllocatorCreate(size_t writableSpace, size_t readableSp
readableSpace += sizeof(FIRCLSAllocator); // add the space for our allocator itself

// we can only protect at the page level, so we need all of our regions to be
// exact multples of pages. But, we don't need anything in the special-case of zero.
// exact multiples of pages. But, we don't need anything in the special-case of zero.

writableRegion.size = 0;
if (writableSpace > 0) {
Expand All @@ -55,7 +55,7 @@ FIRCLSAllocatorRef FIRCLSAllocatorCreate(size_t writableSpace, size_t readableSp
readableRegion.size = ((readableSpace / pageSize) + 1) * pageSize;
}

// Make one big, continous allocation, adding additional pages for our guards. Note
// Make one big, continuous allocation, adding additional pages for our guards. Note
// that we cannot use malloc (or valloc) in this case, because we need to assert full
// ownership over these allocations. mmap is a much better choice. We also mark these
// pages as MAP_NOCACHE.
Expand Down
2 changes: 1 addition & 1 deletion FirebaseMessaging/Sources/FIRMessagingPubSub.m
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ + (NSRegularExpression *)topicRegex {
}

/**
* Gets the class describing occurences of topic names and sender IDs in the sender.
* Gets the class describing occurrences of topic names and sender IDs in the sender.
*
* @param topic The topic expression used to generate a pubsub topic
*
Expand Down
2 changes: 1 addition & 1 deletion docs/AddNewPod.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ explicit import by other Firebase pods)

See [Headers and Imports](HeadersImports.md) for details on managing headers and imports.

## Continous Integration
## Continuous Integration

Set up a GitHub Action workflow for the pod. A good example template is
[storage.yml](.github/workflows/storage.yml).
Expand Down
2 changes: 1 addition & 1 deletion docs/AddNewProduct.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ non-Google open source project should be nested under a `third_party` directory.
* `FirebaseFoo/Tests/Sample` - Optional
* `FirebaseFoo/Tests/{Other}` - Optional

## Continous Integration
## Continuous Integration

Set up a GitHub Action workflow for the pod. A good example template is
[storage.yml](.github/workflows/storage.yml).
Expand Down
Loading