Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release Tooling] Consistent approach to resources when building on Xcode 15 #12821

Merged
merged 12 commits into from
Apr 23, 2024
Merged

[Release Tooling] Consistent approach to resources when building on Xcode 15 #12821

merged 12 commits into from
Apr 23, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 19, 2024 •
edited
Loading

In practice, this PR will remove the gRPC-Certificates.bundle and add the FIAM UI resource bundle into the framework (rather than alongside it).

Checks on green CI:

  • No more top-level resource directories.
  • Updated METADATA.md (no more resources outside of xcframeworks)
  • No more gRPC-Certificates.bundle (fix Is gRPCCertificates-Cpp.bundle necessary? #9184)
  • Test embedded version of FIAM to ensure bundle is findable. (as of 09efe72)
  • Test upload with all XCFrameworks (iOS, MacCatalyst, macOS)
    • I was able to validate that iOS and macOS apps archive, but am having certs trouble getting to the App Store Connect part.

#no-changelog

@google-oss-bot
Copy link

google-oss-bot commented Apr 19, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    Overall coverage changed from 44.66% (020264b) to 44.57% (8ecd9b6) by -0.09%.

    FilenameBase (020264b)Merge (8ecd9b6)Diff
    FIRIAMDefaultDisplayImpl.m1.78%1.72%-0.06%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zXQxYW8f5b.html

@ncooke3 ncooke3 marked this pull request as ready for review April 23, 2024 14:04
paulb777
paulb777 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolving the numbering question.

ReleaseTooling/Template/README.md Outdated Show resolved Hide resolved
@ncooke3 ncooke3 enabled auto-merge (squash) April 23, 2024 14:36
@ncooke3 ncooke3 disabled auto-merge April 23, 2024 14:37
@ncooke3 ncooke3 merged commit ee81927 into main Apr 23, 2024
5 checks passed
@ncooke3 ncooke3 deleted the nc/rt-xcode15 branch April 23, 2024 14:37
ncooke3 added a commit that referenced this pull request Apr 23, 2024
@ncooke3
[Release] Update FIAM 10.25.0 changelog to reflect #12821
e29d150
ncooke3 added a commit that referenced this pull request Apr 23, 2024
@ncooke3
[Release] Update FIAM 10.25.0 changelog to reflect #12821 (#12840)
01cad50
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager May 1, 2024
@cgrindel-self-hosted-renovate
chore(deps): update dependency firebase/firebase-ios-sdk to from: "10…
fc086f7 
….25.0" (#1056)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://togithub.com/firebase/firebase-ios-sdk)
| minor | `from: "10.24.0"` -> `from: "10.25.0"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.25.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.25.0):
Firebase Apple 10.25.0

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.24.0...10.25.0)

The Firebase Apple SDK (10.25.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.25.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- \[FirebaseCoreInternal] Switch to implementation-only import of GULs
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12714](https://togithub.com/firebase/firebase-ios-sdk/pull/12714)
- \[AppCheck, Database, InAppMessaging, MLModelDownloader, Performance,
Sessions] Migrate to GoogleUtilities's storage container by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[#&#8203;12752](https://togithub.com/firebase/firebase-ios-sdk/issues/12752),
[#&#8203;12753](https://togithub.com/firebase/firebase-ios-sdk/issues/12753),
[#&#8203;12757](https://togithub.com/firebase/firebase-ios-sdk/issues/12757),
[#&#8203;12759](https://togithub.com/firebase/firebase-ios-sdk/issues/12759),
[#&#8203;12762](https://togithub.com/firebase/firebase-ios-sdk/issues/12762),
[#&#8203;12773](https://togithub.com/firebase/firebase-ios-sdk/issues/12773)
- Use declspec in Firestore on Windows machines by
[@&#8203;a-maurice](https://togithub.com/a-maurice) in
[https://github.com/firebase/firebase-ios-sdk/pull/12758](https://togithub.com/firebase/firebase-ios-sdk/pull/12758)
- \[CI] Stop Xcode 14, start Xcode 15.3 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12746](https://togithub.com/firebase/firebase-ios-sdk/pull/12746)
- \[Performance] Migrate to GoogleUtilities's storage container by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12759](https://togithub.com/firebase/firebase-ios-sdk/pull/12759)
- Todos and workarounds for tests not yet ready for macos-14 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12781](https://togithub.com/firebase/firebase-ios-sdk/pull/12781)
- Another macos-14 CI workaround by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12787](https://togithub.com/firebase/firebase-ios-sdk/pull/12787)
- \[CI] Update grpc dependent jobs to macos-14 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12790](https://togithub.com/firebase/firebase-ios-sdk/pull/12790)
- \[Firestore] Remove DocumentID setter warning by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12756](https://togithub.com/firebase/firebase-ios-sdk/pull/12756)
- \[App Check] Bump dependency on AppCheckCore to 10.19.0+ by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12806](https://togithub.com/firebase/firebase-ios-sdk/pull/12806)
- Allow Blob of data with zero length. by
[@&#8203;tom-andersen](https://togithub.com/tom-andersen) in
[https://github.com/firebase/firebase-ios-sdk/pull/12694](https://togithub.com/firebase/firebase-ios-sdk/pull/12694)
- \[Infra] Switch zip building over to Xcode 15.2 by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12737](https://togithub.com/firebase/firebase-ios-sdk/pull/12737)
- Make use of
SQLITE_OPEN_FILEPROTECTION_COMPLETEUNTILFIRSTUSERAUTHENTICATION
conditional. by
[@&#8203;cprince-foreflight](https://togithub.com/cprince-foreflight) in
[https://github.com/firebase/firebase-ios-sdk/pull/12548](https://togithub.com/firebase/firebase-ios-sdk/pull/12548)
- \[Release Tooling] Consistent approach to resources when building on
Xcode 15 by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12821](https://togithub.com/firebase/firebase-ios-sdk/pull/12821)
- \[Release Tooling] Cleanup unused folder references by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12825](https://togithub.com/firebase/firebase-ios-sdk/pull/12825)
- Analytics 10.25.0 by [@&#8203;pcfba](https://togithub.com/pcfba) in
[https://github.com/firebase/firebase-ios-sdk/pull/12843](https://togithub.com/firebase/firebase-ios-sdk/pull/12843)
- Update `FIRAuthInterop` to use `_Nullable_result` annotation by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12841](https://togithub.com/firebase/firebase-ios-sdk/pull/12841)
- Disable quickstart CI that doesn't work with Xcode 15 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12846](https://togithub.com/firebase/firebase-ios-sdk/pull/12846)

#### New Contributors

- [@&#8203;mrs1669](https://togithub.com/mrs1669) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12760](https://togithub.com/firebase/firebase-ios-sdk/pull/12760)
- [@&#8203;a-maurice](https://togithub.com/a-maurice) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12758](https://togithub.com/firebase/firebase-ios-sdk/pull/12758)
- [@&#8203;cprince-foreflight](https://togithub.com/cprince-foreflight)
made their first contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12548](https://togithub.com/firebase/firebase-ios-sdk/pull/12548)

**Full Changelog**:
firebase/firebase-ios-sdk@10.24.0...10.25.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
api: inappmessaging Firebase In App Messaging release-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is gRPCCertificates-Cpp.bundle necessary?
4 participants
@ncooke3 @google-oss-bot @paulb777 @andrewheard