[Vertex AI] Update Citation decoding to handle optional startIndex
#12832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Apr 22, 2024
andrewheard
added a commit
that referenced
this pull request
May 1, 2024
andrewheard
added a commit
that referenced
this pull request
May 13, 2024
andrewheard
added a commit
that referenced
this pull request
May 13, 2024
1998code
pushed a commit
to 1998code/firebase-ios-sdk
that referenced
this pull request
May 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
Citationdecoding to handle optional values forstartIndex(defaults to0when omitted). This is a port of google-gemini/generative-ai-swift#135 and google-gemini/generative-ai-swift#141, where applicable (Vertex AI does not return""whenlicenseis empty so this functionality was not copied).#no-changelog