Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Integrate with AuthInterop #12856

Merged
merged 5 commits into from
Apr 29, 2024
Merged

[Vertex AI] Integrate with AuthInterop #12856

merged 5 commits into from
Apr 29, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Apr 26, 2024 •
edited
Loading

Integrated with AuthInterop, adding Authorization headers to Vertex AI requests when Firebase Auth is available and signed in.

#no-changelog

paulb777
paulb777 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manually confirmed that Storage succeeds and fails based on a good and bad auth?

@andrewheard
Copy link
Contributor Author

Did you manually confirmed that Storage succeeds and fails based on a good and bad auth?

@paulb777 Yep, the Storage rules worked as expected too (a completely public file was accessible without auth and files that required auth failed when the token was missing).

@andrewheard andrewheard merged commit 239ef8f into vertex-ai Apr 29, 2024
176 checks passed
@andrewheard andrewheard deleted the ah/vertex-ai-auth branch April 29, 2024 20:17
@andrewheard andrewheard changed the title [Vertex AI] Integrate with AppCheckInterop [Vertex AI] Integrate with AuthInterop Apr 30, 2024
andrewheard added a commit that referenced this pull request May 1, 2024
@andrewheard
[Vertex AI] Integrate with AppCheckInterop (#12856)
d675a68
andrewheard added a commit that referenced this pull request May 13, 2024
@andrewheard
[Vertex AI] Integrate with AppCheckInterop (#12856)
e78c4fc
andrewheard added a commit that referenced this pull request May 13, 2024
@andrewheard
[Vertex AI] Integrate with AppCheckInterop (#12856)
54e4ef4
1998code pushed a commit to 1998code/firebase-ios-sdk that referenced this pull request May 14, 2024
@andrewheard @1998code
[Vertex AI] Integrate with AppCheckInterop (firebase#12856)
948df07
@firebase firebase locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: auth api: functions api: storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @paulb777 @google-oss-bot