Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firestore] Cleanup compilation guards for building on older SDKs #12936

Merged
merged 1 commit into from
May 10, 2024
Merged

[Firestore] Cleanup compilation guards for building on older SDKs #12936

merged 1 commit into from
May 10, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 10, 2024

#no-changelog

@ncooke3 ncooke3 changed the title [Infra] Cleanup compilation guards for building on older SDKs [Firestore] Cleanup compilation guards for building on older SDKs May 10, 2024
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.18% (d9f9382) to 88.12% (ebd3e68) by -0.06%.

    FilenameBase (d9f9382)Merge (ebd3e68)Diff
    exception.cc84.21%23.68%-60.53%
    grpc_stream.cc99.01%98.02%-0.99%
    leveldb_key.cc98.63%98.82%+0.20%
    leveldb_remote_document_cache.cc94.83%96.55%+1.72%
    local_serializer.cc87.78%88.33%+0.56%
    ordered_code.cc93.90%94.39%+0.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fdr2ChiSLD.html

@ncooke3 ncooke3 requested a review from wu-hui May 10, 2024 17:22
@ncooke3 ncooke3 merged commit 8e2c7b7 into main May 10, 2024
49 checks passed
@ncooke3 ncooke3 deleted the nc/firestore branch May 10, 2024 17:26
@firebase firebase locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@wu-hui wu-hui Awaiting requested review from wu-hui

Assignees
No one assigned
Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @google-oss-bot @paulb777