Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIAM] Cleanup compilation guards for building on older SDKs #12937

Merged
merged 2 commits into from
May 10, 2024
Merged

[FIAM] Cleanup compilation guards for building on older SDKs #12937

merged 2 commits into from
May 10, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 10, 2024

#no-changelog

@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label May 10, 2024
@google-oss-bot
Copy link

google-oss-bot commented May 10, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    Overall coverage changed from 44.42% (a2d205c) to 44.61% (12a9d1d) by +0.19%.

    FilenameBase (a2d205c)Merge (12a9d1d)Diff
    FIRIAMActivityLogger.m60.96%60.54%-0.42%
    FIRIAMClearcutLogStorage.m62.50%62.00%-0.50%
    FIRIAMClearcutUploader.m90.34%90.23%-0.11%
    FIRIAMDisplayExecutor.m66.96%66.76%-0.20%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9BtYpQkJMh.html

@ncooke3 ncooke3 requested a review from andrewheard May 10, 2024 18:10
@ncooke3 ncooke3 merged commit 38aabb1 into main May 10, 2024
45 checks passed
@ncooke3 ncooke3 deleted the nc/fiam branch May 10, 2024 19:16
@firebase firebase locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @google-oss-bot @paulb777 @andrewheard