Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Attempt to fix #12769 #12938

Merged
merged 3 commits into from
May 10, 2024
Merged

[Infra] Attempt to fix #12769 #12938

merged 3 commits into from
May 10, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 10, 2024 •
edited
Loading

Unblocks #12934

Fix #12769

#no-changelog

@google-oss-bot
Copy link

google-oss-bot commented May 10, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.19% (a2d205c) to 88.12% (7ed0b29) by -0.07%.

    FilenameBase (a2d205c)Merge (7ed0b29)Diff
    exception.cc84.21%23.68%-60.53%
    grpc_stream.cc98.02%99.01%+0.99%
    leveldb_key.cc98.43%98.82%+0.39%
    local_serializer.cc88.33%87.78%-0.56%
    ordered_code.cc93.90%94.39%+0.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cTaIcX5ruv.html

@ncooke3 ncooke3 requested a review from paulb777 May 10, 2024 17:45
@ncooke3 ncooke3 requested a review from andrewheard May 10, 2024 17:46
@ncooke3
Copy link
Member Author

ncooke3 commented May 10, 2024

green CI in 938963e. Comment removed in latest commit

@ncooke3 ncooke3 merged commit 07c7c34 into main May 10, 2024
48 checks passed
@ncooke3 ncooke3 deleted the nc/12769 branch May 10, 2024 18:07
@ncooke3 ncooke3 mentioned this pull request May 10, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@paulb777 paulb777 Awaiting requested review from paulb777

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Firestore CI] cmake tests migration to macos-14
3 participants
@ncooke3 @google-oss-bot @andrewheard