Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VisionOS and WatchOS CI #12966

Merged
merged 6 commits into from
May 15, 2024
Merged

Fix VisionOS and WatchOS CI #12966

merged 6 commits into from
May 15, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented May 14, 2024

The -sdk option was missing for xcodebuild causing the builds and tests to run for macOS instead.

Three issues found and fixed or worked around:

  • Missing VISION_OS ifdef in FIAM (may be more)
  • The watch OS messaging sample app doesn't build for the watchOS target because of nanopb and promises having minimum version of 2.0 when Xcode 15 only supports down to 4.0.
  • The spm tests don't build because of missing Firestore and Analytics. Probably sufficient for now to leave SPM testing to the individual products.

@ncooke3
Copy link
Member

ncooke3 commented May 14, 2024

One of the failing tests is due to visionOS not being available for Firestore binary: https://github.com/firebase/firebase-ios-sdk/actions/runs/9084812253/job/24966694977?pr=12966#step:6:438

One option is to set the env var to build it from source for the visionOS flow.

@paulb777
Copy link
Member Author

Thanks @ncooke3 - I'll make the update when I have a fix for the other Messaging Watch Sample app build problem.

@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label May 14, 2024
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented May 14, 2024

Coverage Report 1

Affected Products

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    Overall coverage changed from ? (5a1763b) to 44.57% (b673e93) by ?.

    45 individual files with coverage change

    FilenameBase (5a1763b)Merge (b673e93)Diff
    CustomInAppMessageDisplayViewModifier.swift?0.00%?
    FIRIAMActionURLFollower.m?52.78%?
    FIRIAMActivityLogger.m?60.54%?
    FIRIAMAnalyticsEventLoggerImpl.m?60.71%?
    FIRIAMBannerViewController.m?0.00%?
    FIRIAMBannerViewUIWindow.m?0.00%?
    FIRIAMBaseRenderingViewController.m?0.00%?
    FIRIAMBookKeeper.m?85.98%?
    FIRIAMCardViewController.m?0.00%?
    FIRIAMClearcutHttpRequestSender.m?0.00%?
    FIRIAMClearcutLogger.m?62.50%?
    FIRIAMClearcutLogStorage.m?62.00%?
    FIRIAMClearcutUploader.m?90.23%?
    FIRIAMClientInfoFetcher.m?61.98%?
    FIRIAMDefaultDisplayImpl.m?1.63%?
    FIRIAMDisplayCheckOnAnalyticEventsFlow.m?0.00%?
    FIRIAMDisplayCheckOnAppForegroundFlow.m?0.00%?
    FIRIAMDisplayCheckOnFetchDoneNotificationFlow.m?0.00%?
    FIRIAMDisplayCheckTriggerFlow.m?0.00%?
    FIRIAMDisplayExecutor.m?66.37%?
    FIRIAMDisplayTriggerDefinition.m?68.42%?
    FIRIAMElapsedTimeTracker.m?92.31%?
    FIRIAMFetchFlow.m?80.35%?
    FIRIAMFetchOnAppForegroundFlow.m?0.00%?
    FIRIAMFetchResponseParser.m?86.11%?
    FIRIAMImageOnlyViewController.m?0.00%?
    FIRIAMMessageClientCache.m?78.36%?
    FIRIAMMessageContentDataWithImageURL.m?80.88%?
    FIRIAMMessageDefinition.m?100.00%?
    FIRIAMModalViewController.m?0.00%?
    FIRIAMMsgFetcherUsingRestful.m?71.01%?
    FIRIAMRenderingEffectSetting.m?100.00%?
    FIRIAMRenderingWindowHelper.m?0.00%?
    FIRIAMRuntimeManager.m?0.00%?
    FIRIAMSDKModeManager.m?93.22%?
    FIRIAMSDKSettings.m?0.00%?
    FIRIAMServerMsgFetchStorage.m?0.00%?
    FIRIAMTimeFetcher.m?0.00%?
    FIRInAppMessaging+Bootstrap.m?0.00%?
    FIRInAppMessaging.m?3.37%?
    FIRInAppMessagingRenderingDataClasses.m?89.29%?
    NSString+FIRInterlaceStrings.m?100.00%?
    SwiftUIPreviewHelpers.swift?0.00%?
    UIApplication+FIRForegroundWindowScene.m?0.00%?
    UIColor+FIRIAMHexString.m?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1rD2z2t8kQ.html

@paulb777 paulb777 requested a review from ncooke3 May 15, 2024 00:00
@paulb777 paulb777 merged commit 95cf485 into main May 15, 2024
73 checks passed
@paulb777 paulb777 deleted the pb-vision-watch-ci-fix branch May 15, 2024 14:38
@firebase firebase locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants