Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for FDL #12999

Merged
merged 3 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/dynamiclinks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Xcode
run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
- name: FirebaseDynamicLinks
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseDynamicLinks.podspec
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseDynamicLinks.podspec --allow-warnings
ncooke3 marked this conversation as resolved.
Show resolved Hide resolved

spm:
# Don't run on private repo unless it is a PR.
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
- name: Setup Bundler
run: scripts/setup_bundler.sh
- name: PodLibLint Storage Cron
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseDynamicLinks.podspec --platforms=ios ${{ matrix.flags }}
run: scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseDynamicLinks.podspec --platforms=ios ${{ matrix.flags }} --allow-warnings

quickstart:
# Don't run on private repo unless it is a PR.
Expand Down
3 changes: 3 additions & 0 deletions FirebaseDynamicLinks/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Unreleased
- [added] Added deprecation warning in advance of August 25, 2025 Dynamic Links service shutdown. (#12995)

# 10.3.0
- [fixed] Fixes issue where `utmParametersDictionary` / `minimumAppVersion` were not provided and their value were set to `[NSNull null]` instead of `nil`.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ NS_ASSUME_NONNULL_BEGIN
* @abstract A class that checks for pending Dynamic Links and parses URLs.
* This class is available on iOS only.
*/

DEPRECATED_MSG_ATTRIBUTE(
"Firebase Dynamic Links is deprecated and the service will shut down on August 25, 2025.")
NS_EXTENSION_UNAVAILABLE_IOS("Firebase Dynamic Links is not supported for iOS extensions.")
API_UNAVAILABLE(macos, tvos, watchos)
NS_SWIFT_NAME(DynamicLinks)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public let shared = Manifest(
Pod("FirebaseAuth", zip: true),
Pod("FirebaseCrashlytics", zip: true),
Pod("FirebaseDatabase", platforms: ["ios", "macos", "tvos"], zip: true),
Pod("FirebaseDynamicLinks", platforms: ["ios"], zip: true),
Pod("FirebaseDynamicLinks", allowWarnings: true, platforms: ["ios"], zip: true),
Pod("FirebaseFirestoreInternal", allowWarnings: true, platforms: ["ios", "macos", "tvos"]),
Pod("FirebaseFirestore", allowWarnings: true, platforms: ["ios", "macos", "tvos"], zip: true),
Pod("FirebaseFunctions", zip: true),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ struct SpecRepoBuilder: ParsableCommand {
func pushPodspec(forPod pod: URL, sdkRepo: String, sources: [String],
flags: [String], shell: Shell = Shell.shared) throws -> Int32 {
let sourcesArg = sources.joined(separator: ",")
let flagsArgArr = allowWarnings ?flags + ["--allow-warnings"] : flags
let flagsArgArr = allowWarnings ? flags + ["--allow-warnings"] : flags
let flagsArg = flagsArgArr.joined(separator: " ")

do {
Expand Down
2 changes: 2 additions & 0 deletions scripts/health_metrics/pod_test_code_coverage_report.sh
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ if [ $SDK == "FirebasePerformance" ]; then
elif [ $SDK == "FirebaseFirestore" ]; then
scripts/install_prereqs.sh Firestore ${PLATFORM} xcodebuild
scripts/third_party/travis/retry.sh scripts/build.sh Firestore ${PLATFORM} xcodebuild
elif [ $SDK == "FirebaseDynamicLinks" ]; then
scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb "${SDK}".podspec --verbose --allow-warnings --platforms="$(tr '[:upper:]' '[:lower:]'<<<${PLATFORM})" --test-specs="${TEST_SPEC}"
else
# Run unit tests of pods and put xcresult bundles into OUTPUT_PATH, which
# should be a targeted dir of actions/upload-artifact in workflows.
Expand Down
Loading