[storage] Migrate to actor to fix a potential data race in initialization

[paulb777]

Fix #13369

Moves fetcherService to an actor

Not only should it fix the issue, the code and tests are more compact and readable.

Removed unnecessary availability checks that were incorrectly setting watchOS to 8

[github-actions]

Apple API Diff Report

Commit: 237941b
Last updated: Wed Jul 31 19:48 PDT 2024
View workflow logs & download artifacts

---

FirebaseStorage

Classes

StorageReference

[MODIFIED] listAll()

Swift:
+  open func listAll () async throws -> StorageListResult
-  @available(iOS 13, tvOS 13, macOS 10.15, watchOS 8, *) open func listAll () async throws -> StorageListResult

[MODIFIED] delete()

Swift:
+  open func delete () async throws
-  @available(iOS 13, tvOS 13, macOS 10.15, watchOS 8, *) open func delete () async throws

[MODIFIED] getMetadata()

Swift:
+  open func getMetadata () async throws -> StorageMetadata
-  @available(iOS 13, tvOS 13, macOS 10.15, watchOS 8, *) open func getMetadata () async throws -> StorageMetadata

[MODIFIED] updateMetadata(_:)

Swift:
+  open func updateMetadata ( _ metadata : StorageMetadata ) async throws -> StorageMetadata
-  @available(iOS 13, tvOS 13, macOS 10.15, watchOS 8, *) open func updateMetadata ( _ metadata : StorageMetadata ) async throws -> StorageMetadata

[MODIFIED] downloadURL()

Swift:
+  open func downloadURL () async throws -> URL
-  @available(iOS 13, tvOS 13, macOS 10.15, watchOS 8, *) open func downloadURL () async throws -> URL

---

[paulb777]

I'll merge here as incremental progress - and plan to address the statics in the new actor in a subsequent PR.