Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Add pod to FirebaseManifest #13586

Merged
merged 3 commits into from
Sep 9, 2024
Merged

[Vertex AI] Add pod to FirebaseManifest #13586

merged 3 commits into from
Sep 9, 2024

Conversation

andrewheard
Copy link
Contributor

Added the FirebaseVertexAI pod to the FirebaseManifest.

Note: Currently needs allowWarnings: true because we emit the following warning on watchOS and tvOS.

#if !os(macOS) && !os(iOS)
#warning("Only iOS, macOS, and Catalyst targets are currently fully supported.")
#endif

#no-changelog

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green zip build and tests and testing the zip binary instructions in a Vertex AI sample app.

Also, ok to punt this to next milestone since it seems a bit tight.

@andrewheard andrewheard marked this pull request as ready for review September 9, 2024 20:26
@andrewheard
Copy link
Contributor Author

LGTM on green zip build and tests and testing the zip binary instructions in a Vertex AI sample app.

I tested the zip (see #13607) and CocoaPods (see #13609) integrations in our sample app and didn't notice any issues.

Note: Although the version is 11.2-beta, zip and pod support won't be available until the Firebase 11.3 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants