[Auth] Convert LoginView to SwiftUI #13628
Conversation
| accentColor: .white, | ||
| backgroundColor: .orange | ||
| ) { | ||
| Task { |
There was a problem hiding this comment.
I'd refactor the code in this closure into a function on the view. Or maybe even into a view model.
There was a problem hiding this comment.
Refactored out into a function on the view. I'll leave this thread open to consider doing a view model. For now, I'll focus on refactoring the UI bits..
| } | ||
| } | ||
| .alert("Enter one time passcode.", isPresented: $showingAlert) { | ||
| TextField("Verification Code", text: $onetimePasscode) |
There was a problem hiding this comment.
To keep the view's body readable, this should probably be a standalone view or a view builder function on the surrounding view
There was a problem hiding this comment.
Hmm, sorry could you explain this a little bit more? I'm not fully following.
| createAccountButton.centerXAnchor.constraint(equalTo: centerXAnchor), | ||
| createAccountButton.topAnchor.constraint(equalTo: loginButton.bottomAnchor, constant: 5), | ||
| ]) | ||
| // TODO(ncooke3): Use view modifiers? |
There was a problem hiding this comment.
Or implement a custom button style.
There was a problem hiding this comment.
Yes, a button style sounds good. When I tried to create a very simple button style, the custom style lost the button's default ability to change text color on tap. I feel like I'm not doing something right if I have to reimplement basic button effects.
private struct MyButtonStyle : ButtonStyle {
func makeBody(configuration: Configuration) -> some View {
configuration.label
}
}
#Preview {
Button("Hello") {}
.buttonStyle(MyButtonStyle())
}
Should I leave this as is? What's the most idiomatic pattern?
There was a problem hiding this comment.
Current render:
Any feedback welcome.
#no-changelog