Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility for GTMSessionFetcher 4 #13734

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add compatibility for GTMSessionFetcher 4 #13734

merged 1 commit into from
Sep 30, 2024

Conversation

paulb777
Copy link
Member

Fix #13729

This should be a functional no-op for Firebase since GTMSessionFetcher 4 only restricts iOS version support to a subset of Firebase's.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

ncooke3
ncooke3 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus Package.swift changes

@paulb777
Copy link
Member Author

GTMSessionFetcher restores iOS 12. Retriggering CI

@paulb777 paulb777 closed this Sep 30, 2024
@paulb777 paulb777 reopened this Sep 30, 2024
@paulb777 paulb777 merged commit 91e6f2b into main Sep 30, 2024
224 of 229 checks passed
@paulb777 paulb777 deleted the pb-gtms4 branch September 30, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: auth api: functions api: storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support both GTMSessionFetcher 3.x and 4.x
3 participants
@paulb777 @google-oss-bot @ncooke3