Fix a crash related to thread sanitization on variables in FPRNetworkTrace class. #13795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
reviewed
Oct 3, 2024
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
|
I'm curious if you all were able to reproduce this issue and if so, how? |
Unfortunately no. It is a race condition and it is very tricky to get this issue reproduced. But the change here is defensive to make sure we don't get into race conditions. |
paulb777
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with @PolinaGo on this issue to resolve it.
Fix #13581