Address negative zero lint validation (#3820)

firebase · Sep 21, 2020 · 16c6ba9 · 16c6ba9
1 parent 7bf7379
commit 16c6ba9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/moody-jobs-deliver.md b/.changeset/moody-jobs-deliver.md
@@ -0,0 +1,5 @@
+---
+"@firebase/firestore": patch
+---
+
+Fixes a "Comparison with -0" lint warning for customers that build from source.
diff --git a/packages/firestore/src/util/types.ts b/packages/firestore/src/util/types.ts
@@ -31,7 +31,7 @@ export function isNullOrUndefined(value: unknown): value is null | undefined {
 export function isNegativeZero(value: number): boolean {
   // Detect if the value is -0.0. Based on polyfill from
   // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is
-  return value === -0 && 1 / value === 1 / -0;
+  return value === 0 && 1 / value === 1 / -0;
 }
 
 /**