Remove makeConstructorPrivate (#3309)

.changeset/small-ghosts-visit.md

@@ -0,0 +1,6 @@
+---
+"firebase": patch
+"@firebase/firestore": patch
+---
+
+Removed internal wrapper around our public API that was meant to prevent incorrect SDK usage for JavaScript users, but caused our SDK to stop working in IE11.

packages/firestore/src/api/field_value.ts

@@ -210,6 +210,10 @@ export class NumericIncrementFieldValueImpl extends SerializableFieldValue {
 /** The public FieldValue class of the lite API. */
 export abstract class FieldValue extends SerializableFieldValue
   implements firestore.FieldValue {
+  protected constructor() {
+    super();
+  }
+
   static delete(): firestore.FieldValue {
     validateNoArgs('FieldValue.delete', arguments);
     return new FieldValueDelegate(

packages/firestore/src/config.ts

@@ -21,75 +21,37 @@ import { _FirebaseNamespace } from '@firebase/app-types/private';
 import { Component, ComponentType, Provider } from '@firebase/component';
 import {
   CACHE_SIZE_UNLIMITED,
-  Firestore,
+  CollectionReference,
   DocumentReference,
   DocumentSnapshot,
-  QueryDocumentSnapshot,
+  Firestore,
   Query,
+  QueryDocumentSnapshot,
   QuerySnapshot,
-  CollectionReference,
   Transaction,
   WriteBatch
 } from './api/database';
 import { Blob } from './api/blob';
 import { FieldPath } from './api/field_path';
 import { GeoPoint } from './api/geo_point';
 import { Timestamp } from './api/timestamp';
-import { makeConstructorPrivate } from './util/api';
 import { FieldValue } from './api/field_value';
 
-// Public instance that disallows construction at runtime. Note that this still
-// allows instanceof checks.
-export const PublicFirestore = makeConstructorPrivate(
+const firestoreNamespace = {
   Firestore,
-  'Use firebase.firestore() instead.'
-);
-export const PublicTransaction = makeConstructorPrivate(
+  GeoPoint,
+  Timestamp,
+  Blob,
   Transaction,
-  'Use firebase.firestore().runTransaction() instead.'
-);
-export const PublicWriteBatch = makeConstructorPrivate(
   WriteBatch,
-  'Use firebase.firestore().batch() instead.'
-);
-export const PublicDocumentReference = makeConstructorPrivate(
   DocumentReference,
-  'Use firebase.firestore().doc() instead.'
-);
-export const PublicDocumentSnapshot = makeConstructorPrivate(DocumentSnapshot);
-export const PublicQueryDocumentSnapshot = makeConstructorPrivate(
-  QueryDocumentSnapshot
-);
-export const PublicQuery = makeConstructorPrivate(Query);
-export const PublicQuerySnapshot = makeConstructorPrivate(QuerySnapshot);
-export const PublicCollectionReference = makeConstructorPrivate(
+  DocumentSnapshot,
+  Query,
+  QueryDocumentSnapshot,
+  QuerySnapshot,
   CollectionReference,
-  'Use firebase.firestore().collection() instead.'
-);
-export const PublicFieldValue = makeConstructorPrivate(
-  FieldValue,
-  'Use FieldValue.<field>() instead.'
-);
-export const PublicBlob = makeConstructorPrivate(
-  Blob,
-  'Use Blob.fromUint8Array() or Blob.fromBase64String() instead.'
-);
-
-const firestoreNamespace = {
-  Firestore: PublicFirestore,
-  GeoPoint,
-  Timestamp,
-  Blob: PublicBlob,
-  Transaction: PublicTransaction,
-  WriteBatch: PublicWriteBatch,
-  DocumentReference: PublicDocumentReference,
-  DocumentSnapshot: PublicDocumentSnapshot,
-  Query: PublicQuery,
-  QueryDocumentSnapshot: PublicQueryDocumentSnapshot,
-  QuerySnapshot: PublicQuerySnapshot,
-  CollectionReference: PublicCollectionReference,
   FieldPath,
-  FieldValue: PublicFieldValue,
+  FieldValue,
   setLogLevel: Firestore.setLogLevel,
   CACHE_SIZE_UNLIMITED
 };