Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Util version bump #3472

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Util version bump #3472

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12999f4
Util patch bump
hsubox76 Jul 24, 2020
784e8ef
Update bump to minor
hsubox76 Jul 24, 2020
756f99a
Revert firebase bump to patch
hsubox76 Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/short-cars-scream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@firebase/analytics': patch
'@firebase/util': patch
Copy link
Member

@Feiyang1 Feiyang1 Jul 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

util should be minor. Can you also add what new functions are added to util?

Suggested change
'@firebase/util': patch
'@firebase/util': minor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I suppose firebase should be minor as well then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, because it doesn't cause any API change in firebase

'firebase': patch
---

Fix error where an analytics PR included a change to `@firebase/util`, but
the util package was not properly included in the changeset for a patch bump.
1 change: 0 additions & 1 deletion packages/analytics/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ registerAnalytics(firebase as _FirebaseNamespace);
declare module '@firebase/app-types' {
interface FirebaseNamespace {
analytics(app?: FirebaseApp): FirebaseAnalytics;
isSupported(): Promise<boolean>;
}
interface FirebaseApp {
analytics(): FirebaseAnalytics;
Expand Down