Add custom domain support to callable functions #3825

samtstern · 2020-09-22T14:43:18Z

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

Googlers: see API review here

Testing

Added new unit tests

API Changes

API reviewed

changeset-bot · 2020-09-22T14:43:21Z

🦋 Changeset detected

Latest commit: 05e6e0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@firebase/functions	Minor
firebase	Patch
@firebase/rules-unit-testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2020-09-22T14:57:59Z

Binary Size Report

Affected SDKs

`@firebase/firestore`

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
browser	249 kB	249 kB	+126 B (+0.1%)
esm2017	196 kB	196 kB	+38 B (+0.0%)
main	483 kB	483 kB	+234 B (+0.0%)
module	246 kB	247 kB	+126 B (+0.1%)
react-native	196 kB	196 kB	+38 B (+0.0%)

`@firebase/firestore/exp`

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
browser	189 kB	189 kB	-224 B (-0.1%)
main	477 kB	477 kB	-62 B (-0.0%)
module	189 kB	189 kB	-224 B (-0.1%)
react-native	189 kB	189 kB	-224 B (-0.1%)

`@firebase/firestore/lite`

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
browser	63.6 kB	63.4 kB	-224 B (-0.4%)
main	140 kB	140 kB	-62 B (-0.0%)
module	63.6 kB	63.4 kB	-224 B (-0.4%)
react-native	63.9 kB	63.6 kB	-224 B (-0.4%)

`@firebase/firestore/memory`

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
browser	187 kB	187 kB	+126 B (+0.1%)
esm2017	147 kB	147 kB	+38 B (+0.0%)
main	357 kB	357 kB	+234 B (+0.1%)
module	185 kB	185 kB	+126 B (+0.1%)
react-native	147 kB	147 kB	+38 B (+0.0%)

`@firebase/functions`

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
browser	9.77 kB	10.0 kB	+263 B (+2.7%)
esm2017	7.35 kB	7.59 kB	+238 B (+3.2%)
main	9.89 kB	10.2 kB	+263 B (+2.7%)
module	9.50 kB	9.77 kB	+263 B (+2.8%)

`firebase`

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
firebase-firestore.js	287 kB	287 kB	+126 B (+0.0%)
firebase-firestore.memory.js	227 kB	227 kB	+126 B (+0.1%)
firebase-functions.js	9.94 kB	10.1 kB	+160 B (+1.6%)
firebase.js	830 kB	831 kB	+286 B (+0.0%)

Test Logs

Base (0a1181b1): https://github.com/firebase/firebase-js-sdk/actions/runs/269732197
Head (c79740d7): https://github.com/firebase/firebase-js-sdk/actions/runs/272193288

hsubox76

Looks good, one question, we have to update packages-exp/functions-exp as well with any changes. Would you like to add them here, in a separate PR, or do you want me to take care of it? (I don't mind, should be simple enough to mirror the changes over.)

samtstern · 2020-09-24T11:49:15Z

@hsubox76 I'll give it a try!

…-domain

github-actions · 2020-09-24T12:03:56Z

Changeset File Check ⚠️

Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

@firebase/functions-exp
@firebase/functions-types-exp

Make sure this was intentional.

packages-exp/functions-exp/src/service.ts

hsubox76 · 2020-09-24T15:52:38Z

packages-exp/functions-exp/src/service.ts

@@ -84,7 +86,7 @@ export class FunctionsService implements _FirebaseService {
    readonly app: FirebaseApp,
    authProvider: Provider<FirebaseAuthInternalName>,
    messagingProvider: Provider<FirebaseMessagingName>,
-    readonly region: string = DEFAULT_REGION,
+    regionOrCustomDomain: string = DEFAULT_REGION,


I think this can be private?

So if I make it private then it remains a private instance field, but I want it to just be a constructor arg that's not saved outside this scope. So I think it's correct as-is?

google-oss-bot · 2020-09-25T10:10:32Z

Size Analysis Report

Affected Products

`@firebase/app-exp`

`SDK_VERSION`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.63 kB	? (?)
size_with_ext_deps	?	4.05 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 22 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `SDK_VERSION` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version` `version$1`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_DEFAULT_ENTRY_NAME`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.63 kB	? (?)
size_with_ext_deps	?	4.05 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 21 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_DEFAULT_ENTRY_NAME` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_addComponent`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.61 kB	? (?)
size_with_ext_deps	?	4.02 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_addOrOverwriteComponent`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.67 kB	? (?)
size_with_ext_deps	?	4.09 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_addOrOverwriteComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_apps`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.60 kB	? (?)
size_with_ext_deps	?	4.02 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_clearComponents`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.63 kB	? (?)
size_with_ext_deps	?	4.05 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_clearComponents` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_components`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.61 kB	? (?)
size_with_ext_deps	?	4.02 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_getProvider`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.66 kB	? (?)
size_with_ext_deps	?	4.07 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_getProvider` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_registerComponent`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.61 kB	? (?)
size_with_ext_deps	?	4.03 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`_removeServiceInstance`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.73 kB	? (?)
size_with_ext_deps	?	4.15 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 7 deps `_addComponent` `_getProvider` `_registerComponent` `_removeServiceInstance` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 21 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`deleteApp`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.75 kB	? (?)
size_with_ext_deps	?	4.16 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `deleteApp` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`getApp`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.71 kB	? (?)
size_with_ext_deps	?	5.39 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `getApp` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 21 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`getApps`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.64 kB	? (?)
size_with_ext_deps	?	4.06 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `getApps` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`initializeApp`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	3.69 kB	? (?)
size_with_ext_deps	?	9.05 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `initializeApp` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`FirebaseAppImpl` `PlatformLoggerService`	?
variables	?	Click to show 21 deps `DEFAULT_ENTRY_NAME` `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component` `ComponentContainer`	?

`onLog`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.74 kB	? (?)
size_with_ext_deps	?	5.95 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `isVersionServiceProvider` `onLog` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger` `setUserLogHandler`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`registerVersion`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.61 kB	? (?)
size_with_ext_deps	?	4.03 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	`_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`setLogLevel`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	2.64 kB	? (?)
size_with_ext_deps	?	4.11 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 6 deps `_addComponent` `_registerComponent` `isVersionServiceProvider` `registerCoreComponents` `registerVersion` `setLogLevel`	?
classes	?	`PlatformLoggerService`	?
variables	?	Click to show 20 deps `ERRORS` `ERROR_FACTORY` `PLATFORM_LOG_STRING` `_apps` `_components` `logger` `name$1` `name$2` `name$3` `name$4` `name$5` `name$6` `name$7` `name$8` `name$9` `name$a` `name$b` `name$c` `name$d` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`Logger` `setLogLevel`	?
`@firebase/util`	?	`ErrorFactory`	?
`@firebase/component`	?	`Component`	?

`@firebase/functions-exp`

getFunctions

Size

Type Base (0a1181b) Head (c79740d) Diff

size ? 1.98 kB ? (?)

size_with_ext_deps ? 5.86 kB ? (?)

Dependencies

Type Base (0a1181b) Head (c79740d) Diff

functions ? getFunctions
registerFunctions ?

classes ? ContextProvider
FunctionsService ?

variables ? DEFAULT_REGION
FUNCTIONS_TYPE
name
version ?

External Dependencies

Module Base (0a1181b) Head (c79740d) Diff

@firebase/app-exp ? _getProvider
_registerComponent
registerVersion ?

@firebase/component ? Component ?

`httpsCallable`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	5.33 kB	? (?)
size_with_ext_deps	?	9.92 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 10 deps `_errorForResponse` `call` `codeForHTTPStatus` `decode` `encode` `failAfter` `httpsCallable` `mapValues` `postJSON` `registerFunctions`	?
classes	?	`ContextProvider` `FunctionsError` `FunctionsService`	?
variables	?	Click to show 7 deps `DEFAULT_REGION` `FUNCTIONS_TYPE` `LONG_TYPE` `UNSIGNED_LONG_TYPE` `errorCodeMap` `name` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/util`	?	`FirebaseError`	?
`@firebase/app-exp`	?	`_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`useFunctionsEmulator`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	1.94 kB	? (?)
size_with_ext_deps	?	5.79 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	`registerFunctions` `useFunctionsEmulator`	?
classes	?	`ContextProvider` `FunctionsService`	?
variables	?	`DEFAULT_REGION` `FUNCTIONS_TYPE` `name` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/app-exp`	?	`_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`@firebase/installations-exp`

`deleteInstallations`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	8.90 kB	? (?)
size_with_ext_deps	?	17.3 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 52 deps `broadcastFidChange` `bufferToBase64UrlSafe` `callFidChangeCallbacks` `clearTimedOutRequest` `closeBroadcastChannel` `completeInstallationRegistration` `createInstallationRequest` `deleteInstallationRequest` `deleteInstallations` `encode` `extractAppConfig` `extractAuthTokenInfoFromResponse` `fetchAuthTokenFromServer` `fidChanged` `generateAuthTokenRequest` `generateFid` `getAuthorizationHeader` `getBroadcastChannel` `getDbPromise` `getDeleteEndpoint` `getErrorFromResponse` `getExpiresInFromResponseExpiresIn` `getGenerateAuthTokenEndpoint` `getHeaders` `getHeadersWithAuth` `getId` `getInstallationEntry` `getInstallationsEndpoint` `getKey` `getMissingValueError` `getToken` `hasAuthTokenRequestTimedOut` `hasInstallationRequestTimedOut` `isAuthTokenExpired` `isAuthTokenValid` `isEntryRegistered` `isServerError` `makeAuthTokenRequestInProgressEntry` `refreshAuthToken` `registerInstallation` `registerInstallations` `remove` `retryIfServerError` `set` `sleep` `triggerRegistrationIfNecessary` `update` `updateAuthTokenRequest` `updateInstallationRequest` `updateOrCreateInstallationEntry` `waitUntilAuthTokenRequest` `waitUntilFidRegistration`	?
variables	?	Click to show 23 deps `DATABASE_NAME` `DATABASE_VERSION` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `INSTALLATIONS_API_URL` `INSTALLATIONS_NAME` `INSTALLATIONS_NAME_INTERNAL` `INTERNAL_AUTH_VERSION` `INVALID_FID` `OBJECT_STORE_NAME` `PACKAGE_VERSION` `PENDING_TIMEOUT_MS` `SERVICE` `SERVICE_NAME` `TOKEN_EXPIRATION_BUFFER` `VALID_FID_PATTERN` `broadcastChannel` `dbPromise` `fidChangeCallbacks` `internalFactory` `name` `publicFactory` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/util`	?	`ErrorFactory` `FirebaseError`	?
`idb`	?	`openDb`	?
`@firebase/app-exp`	?	`_getProvider` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`getId`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	8.34 kB	? (?)
size_with_ext_deps	?	16.8 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 49 deps `broadcastFidChange` `bufferToBase64UrlSafe` `callFidChangeCallbacks` `clearTimedOutRequest` `closeBroadcastChannel` `completeInstallationRegistration` `createInstallationRequest` `encode` `extractAppConfig` `extractAuthTokenInfoFromResponse` `fetchAuthTokenFromServer` `fidChanged` `generateAuthTokenRequest` `generateFid` `getAuthorizationHeader` `getBroadcastChannel` `getDbPromise` `getErrorFromResponse` `getExpiresInFromResponseExpiresIn` `getGenerateAuthTokenEndpoint` `getHeaders` `getHeadersWithAuth` `getId` `getInstallationEntry` `getInstallationsEndpoint` `getKey` `getMissingValueError` `getToken` `hasAuthTokenRequestTimedOut` `hasInstallationRequestTimedOut` `isAuthTokenExpired` `isAuthTokenValid` `isEntryRegistered` `isServerError` `makeAuthTokenRequestInProgressEntry` `refreshAuthToken` `registerInstallation` `registerInstallations` `remove` `retryIfServerError` `set` `sleep` `triggerRegistrationIfNecessary` `update` `updateAuthTokenRequest` `updateInstallationRequest` `updateOrCreateInstallationEntry` `waitUntilAuthTokenRequest` `waitUntilFidRegistration`	?
variables	?	Click to show 23 deps `DATABASE_NAME` `DATABASE_VERSION` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `INSTALLATIONS_API_URL` `INSTALLATIONS_NAME` `INSTALLATIONS_NAME_INTERNAL` `INTERNAL_AUTH_VERSION` `INVALID_FID` `OBJECT_STORE_NAME` `PACKAGE_VERSION` `PENDING_TIMEOUT_MS` `SERVICE` `SERVICE_NAME` `TOKEN_EXPIRATION_BUFFER` `VALID_FID_PATTERN` `broadcastChannel` `dbPromise` `fidChangeCallbacks` `internalFactory` `name` `publicFactory` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/util`	?	`ErrorFactory` `FirebaseError`	?
`idb`	?	`openDb`	?
`@firebase/app-exp`	?	`_getProvider` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`getInstallations`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	8.43 kB	? (?)
size_with_ext_deps	?	16.9 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 50 deps `broadcastFidChange` `bufferToBase64UrlSafe` `callFidChangeCallbacks` `clearTimedOutRequest` `closeBroadcastChannel` `completeInstallationRegistration` `createInstallationRequest` `encode` `extractAppConfig` `extractAuthTokenInfoFromResponse` `fetchAuthTokenFromServer` `fidChanged` `generateAuthTokenRequest` `generateFid` `getAuthorizationHeader` `getBroadcastChannel` `getDbPromise` `getErrorFromResponse` `getExpiresInFromResponseExpiresIn` `getGenerateAuthTokenEndpoint` `getHeaders` `getHeadersWithAuth` `getId` `getInstallationEntry` `getInstallations` `getInstallationsEndpoint` `getKey` `getMissingValueError` `getToken` `hasAuthTokenRequestTimedOut` `hasInstallationRequestTimedOut` `isAuthTokenExpired` `isAuthTokenValid` `isEntryRegistered` `isServerError` `makeAuthTokenRequestInProgressEntry` `refreshAuthToken` `registerInstallation` `registerInstallations` `remove` `retryIfServerError` `set` `sleep` `triggerRegistrationIfNecessary` `update` `updateAuthTokenRequest` `updateInstallationRequest` `updateOrCreateInstallationEntry` `waitUntilAuthTokenRequest` `waitUntilFidRegistration`	?
variables	?	Click to show 23 deps `DATABASE_NAME` `DATABASE_VERSION` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `INSTALLATIONS_API_URL` `INSTALLATIONS_NAME` `INSTALLATIONS_NAME_INTERNAL` `INTERNAL_AUTH_VERSION` `INVALID_FID` `OBJECT_STORE_NAME` `PACKAGE_VERSION` `PENDING_TIMEOUT_MS` `SERVICE` `SERVICE_NAME` `TOKEN_EXPIRATION_BUFFER` `VALID_FID_PATTERN` `broadcastChannel` `dbPromise` `fidChangeCallbacks` `internalFactory` `name` `publicFactory` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/util`	?	`ErrorFactory` `FirebaseError`	?
`idb`	?	`openDb`	?
`@firebase/app-exp`	?	`_getProvider` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`getToken`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	8.35 kB	? (?)
size_with_ext_deps	?	16.8 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 49 deps `broadcastFidChange` `bufferToBase64UrlSafe` `callFidChangeCallbacks` `clearTimedOutRequest` `closeBroadcastChannel` `completeInstallationRegistration` `createInstallationRequest` `encode` `extractAppConfig` `extractAuthTokenInfoFromResponse` `fetchAuthTokenFromServer` `fidChanged` `generateAuthTokenRequest` `generateFid` `getAuthorizationHeader` `getBroadcastChannel` `getDbPromise` `getErrorFromResponse` `getExpiresInFromResponseExpiresIn` `getGenerateAuthTokenEndpoint` `getHeaders` `getHeadersWithAuth` `getId` `getInstallationEntry` `getInstallationsEndpoint` `getKey` `getMissingValueError` `getToken` `hasAuthTokenRequestTimedOut` `hasInstallationRequestTimedOut` `isAuthTokenExpired` `isAuthTokenValid` `isEntryRegistered` `isServerError` `makeAuthTokenRequestInProgressEntry` `refreshAuthToken` `registerInstallation` `registerInstallations` `remove` `retryIfServerError` `set` `sleep` `triggerRegistrationIfNecessary` `update` `updateAuthTokenRequest` `updateInstallationRequest` `updateOrCreateInstallationEntry` `waitUntilAuthTokenRequest` `waitUntilFidRegistration`	?
variables	?	Click to show 23 deps `DATABASE_NAME` `DATABASE_VERSION` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `INSTALLATIONS_API_URL` `INSTALLATIONS_NAME` `INSTALLATIONS_NAME_INTERNAL` `INTERNAL_AUTH_VERSION` `INVALID_FID` `OBJECT_STORE_NAME` `PACKAGE_VERSION` `PENDING_TIMEOUT_MS` `SERVICE` `SERVICE_NAME` `TOKEN_EXPIRATION_BUFFER` `VALID_FID_PATTERN` `broadcastChannel` `dbPromise` `fidChangeCallbacks` `internalFactory` `name` `publicFactory` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/util`	?	`ErrorFactory` `FirebaseError`	?
`idb`	?	`openDb`	?
`@firebase/app-exp`	?	`_getProvider` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`onIdChange`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	8.60 kB	? (?)
size_with_ext_deps	?	17.0 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 52 deps `addCallback` `broadcastFidChange` `bufferToBase64UrlSafe` `callFidChangeCallbacks` `clearTimedOutRequest` `closeBroadcastChannel` `completeInstallationRegistration` `createInstallationRequest` `encode` `extractAppConfig` `extractAuthTokenInfoFromResponse` `fetchAuthTokenFromServer` `fidChanged` `generateAuthTokenRequest` `generateFid` `getAuthorizationHeader` `getBroadcastChannel` `getDbPromise` `getErrorFromResponse` `getExpiresInFromResponseExpiresIn` `getGenerateAuthTokenEndpoint` `getHeaders` `getHeadersWithAuth` `getId` `getInstallationEntry` `getInstallationsEndpoint` `getKey` `getMissingValueError` `getToken` `hasAuthTokenRequestTimedOut` `hasInstallationRequestTimedOut` `isAuthTokenExpired` `isAuthTokenValid` `isEntryRegistered` `isServerError` `makeAuthTokenRequestInProgressEntry` `onIdChange` `refreshAuthToken` `registerInstallation` `registerInstallations` `remove` `removeCallback` `retryIfServerError` `set` `sleep` `triggerRegistrationIfNecessary` `update` `updateAuthTokenRequest` `updateInstallationRequest` `updateOrCreateInstallationEntry` `waitUntilAuthTokenRequest` `waitUntilFidRegistration`	?
variables	?	Click to show 23 deps `DATABASE_NAME` `DATABASE_VERSION` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `INSTALLATIONS_API_URL` `INSTALLATIONS_NAME` `INSTALLATIONS_NAME_INTERNAL` `INTERNAL_AUTH_VERSION` `INVALID_FID` `OBJECT_STORE_NAME` `PACKAGE_VERSION` `PENDING_TIMEOUT_MS` `SERVICE` `SERVICE_NAME` `TOKEN_EXPIRATION_BUFFER` `VALID_FID_PATTERN` `broadcastChannel` `dbPromise` `fidChangeCallbacks` `internalFactory` `name` `publicFactory` `version`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/util`	?	`ErrorFactory` `FirebaseError`	?
`idb`	?	`openDb`	?
`@firebase/app-exp`	?	`_getProvider` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`@firebase/performance-exp`

`getPerformance`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	16.8 kB	? (?)
size_with_ext_deps	?	21.8 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 50 deps `addToQueue` `changeInitializationStatus` `configValid` `convertMetricValueToInteger` `createNetworkRequestEntry` `createUserTimingTrace` `dispatchQueueEvents` `getApiKey` `getAppId` `getApplicationInfo` `getAuthTokenPromise` `getConfig` `getDocumentReadyComplete` `getEffectiveConnectionType` `getIid` `getIidPromise` `getInitializationPromise` `getPerformance` `getProjectId` `getRemoteConfig` `getServiceWorkerStatus` `getStoredConfig` `getVisibilityState` `initializePerf` `isPerfInitialized` `isValidCustomAttributeName` `isValidCustomAttributeValue` `isValidMetricName` `logNetworkRequest` `logTrace` `mergeStrings` `postToFlEndpoint` `processConfig` `processQueue` `registerPerformance` `sendEventsToFl` `sendLog` `sendTraceLog` `serializeNetworkRequest` `serializeTrace` `serializer` `setupApi` `setupNetworkRequests` `setupOobResources` `setupOobTraces` `setupTransportService` `setupUserTimingTraces` `shouldLogAfterSampling` `storeConfig` `transportHandler`	?
classes	?	`Api` `PerformanceController` `SettingsService` `Trace`	?
variables	?	Click to show 45 deps `ATTRIBUTE_FORMAT_REGEX` `CONFIG_EXPIRY_LOCAL_STORAGE_KEY` `CONFIG_LOCAL_STORAGE_KEY` `COULD_NOT_GET_CONFIG_MSG` `DEFAULT_CONFIGS` `DEFAULT_ENTRY_NAME` `DEFAULT_REMAINING_TRIES` `DEFAULT_SEND_INTERVAL_MS` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `FID_WAIT_TIME_MS` `FIRST_CONTENTFUL_PAINT_COUNTER_NAME` `FIRST_INPUT_DELAY_COUNTER_NAME` `FIRST_PAINT_COUNTER_NAME` `FIS_AUTH_PREFIX` `INITIAL_SEND_TIME_DELAY_MS` `MAX_ATTRIBUTE_NAME_LENGTH` `MAX_ATTRIBUTE_VALUE_LENGTH` `MAX_METRIC_NAME_LENGTH` `OOB_TRACE_PAGE_LOAD_PREFIX` `REMOTE_CONFIG_SDK_VERSION` `RESERVED_ATTRIBUTE_PREFIXES` `RESERVED_AUTO_PREFIX` `SDK_VERSION` `SERVICE` `SERVICE_NAME` `TRACE_MEASURE_PREFIX` `TRACE_START_MARK_PREFIX` `TRACE_STOP_MARK_PREFIX` `VisibilityState` `apiInstance` `consoleLogger` `factory` `iid` `initializationPromise` `initializationStatus` `isTransportSetup` `logger` `name` `oobMetrics` `queue` `remainingTries` `settingsServiceInstance` `version` `windowInstance`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `isIndexedDBAvailable` `validateIndexedDBOpenable`	?
`@firebase/app-exp`	?	`_getProvider` `_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`registerPerformance`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	16.7 kB	? (?)
size_with_ext_deps	?	21.7 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 49 deps `addToQueue` `changeInitializationStatus` `configValid` `convertMetricValueToInteger` `createNetworkRequestEntry` `createUserTimingTrace` `dispatchQueueEvents` `getApiKey` `getAppId` `getApplicationInfo` `getAuthTokenPromise` `getConfig` `getDocumentReadyComplete` `getEffectiveConnectionType` `getIid` `getIidPromise` `getInitializationPromise` `getProjectId` `getRemoteConfig` `getServiceWorkerStatus` `getStoredConfig` `getVisibilityState` `initializePerf` `isPerfInitialized` `isValidCustomAttributeName` `isValidCustomAttributeValue` `isValidMetricName` `logNetworkRequest` `logTrace` `mergeStrings` `postToFlEndpoint` `processConfig` `processQueue` `registerPerformance` `sendEventsToFl` `sendLog` `sendTraceLog` `serializeNetworkRequest` `serializeTrace` `serializer` `setupApi` `setupNetworkRequests` `setupOobResources` `setupOobTraces` `setupTransportService` `setupUserTimingTraces` `shouldLogAfterSampling` `storeConfig` `transportHandler`	?
classes	?	`Api` `PerformanceController` `SettingsService` `Trace`	?
variables	?	Click to show 45 deps `ATTRIBUTE_FORMAT_REGEX` `CONFIG_EXPIRY_LOCAL_STORAGE_KEY` `CONFIG_LOCAL_STORAGE_KEY` `COULD_NOT_GET_CONFIG_MSG` `DEFAULT_CONFIGS` `DEFAULT_ENTRY_NAME` `DEFAULT_REMAINING_TRIES` `DEFAULT_SEND_INTERVAL_MS` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `FID_WAIT_TIME_MS` `FIRST_CONTENTFUL_PAINT_COUNTER_NAME` `FIRST_INPUT_DELAY_COUNTER_NAME` `FIRST_PAINT_COUNTER_NAME` `FIS_AUTH_PREFIX` `INITIAL_SEND_TIME_DELAY_MS` `MAX_ATTRIBUTE_NAME_LENGTH` `MAX_ATTRIBUTE_VALUE_LENGTH` `MAX_METRIC_NAME_LENGTH` `OOB_TRACE_PAGE_LOAD_PREFIX` `REMOTE_CONFIG_SDK_VERSION` `RESERVED_ATTRIBUTE_PREFIXES` `RESERVED_AUTO_PREFIX` `SDK_VERSION` `SERVICE` `SERVICE_NAME` `TRACE_MEASURE_PREFIX` `TRACE_START_MARK_PREFIX` `TRACE_STOP_MARK_PREFIX` `VisibilityState` `apiInstance` `consoleLogger` `factory` `iid` `initializationPromise` `initializationStatus` `isTransportSetup` `logger` `name` `oobMetrics` `queue` `remainingTries` `settingsServiceInstance` `version` `windowInstance`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `isIndexedDBAvailable` `validateIndexedDBOpenable`	?
`@firebase/app-exp`	?	`_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

`trace`

Size

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
size	?	16.7 kB	? (?)
size_with_ext_deps	?	21.7 kB	? (?)

Dependencies

Type	Base (`0a1181b`)	Head (`c79740d`)	Diff
functions	?	Click to show 50 deps `addToQueue` `changeInitializationStatus` `configValid` `convertMetricValueToInteger` `createNetworkRequestEntry` `createUserTimingTrace` `dispatchQueueEvents` `getApiKey` `getAppId` `getApplicationInfo` `getAuthTokenPromise` `getConfig` `getDocumentReadyComplete` `getEffectiveConnectionType` `getIid` `getIidPromise` `getInitializationPromise` `getProjectId` `getRemoteConfig` `getServiceWorkerStatus` `getStoredConfig` `getVisibilityState` `initializePerf` `isPerfInitialized` `isValidCustomAttributeName` `isValidCustomAttributeValue` `isValidMetricName` `logNetworkRequest` `logTrace` `mergeStrings` `postToFlEndpoint` `processConfig` `processQueue` `registerPerformance` `sendEventsToFl` `sendLog` `sendTraceLog` `serializeNetworkRequest` `serializeTrace` `serializer` `setupApi` `setupNetworkRequests` `setupOobResources` `setupOobTraces` `setupTransportService` `setupUserTimingTraces` `shouldLogAfterSampling` `storeConfig` `trace` `transportHandler`	?
classes	?	`Api` `PerformanceController` `SettingsService` `Trace`	?
variables	?	Click to show 45 deps `ATTRIBUTE_FORMAT_REGEX` `CONFIG_EXPIRY_LOCAL_STORAGE_KEY` `CONFIG_LOCAL_STORAGE_KEY` `COULD_NOT_GET_CONFIG_MSG` `DEFAULT_CONFIGS` `DEFAULT_ENTRY_NAME` `DEFAULT_REMAINING_TRIES` `DEFAULT_SEND_INTERVAL_MS` `ERROR_DESCRIPTION_MAP` `ERROR_FACTORY` `FID_WAIT_TIME_MS` `FIRST_CONTENTFUL_PAINT_COUNTER_NAME` `FIRST_INPUT_DELAY_COUNTER_NAME` `FIRST_PAINT_COUNTER_NAME` `FIS_AUTH_PREFIX` `INITIAL_SEND_TIME_DELAY_MS` `MAX_ATTRIBUTE_NAME_LENGTH` `MAX_ATTRIBUTE_VALUE_LENGTH` `MAX_METRIC_NAME_LENGTH` `OOB_TRACE_PAGE_LOAD_PREFIX` `REMOTE_CONFIG_SDK_VERSION` `RESERVED_ATTRIBUTE_PREFIXES` `RESERVED_AUTO_PREFIX` `SDK_VERSION` `SERVICE` `SERVICE_NAME` `TRACE_MEASURE_PREFIX` `TRACE_START_MARK_PREFIX` `TRACE_STOP_MARK_PREFIX` `VisibilityState` `apiInstance` `consoleLogger` `factory` `iid` `initializationPromise` `initializationStatus` `isTransportSetup` `logger` `name` `oobMetrics` `queue` `remainingTries` `settingsServiceInstance` `version` `windowInstance`	?

External Dependencies

Module	Base (`0a1181b`)	Head (`c79740d`)	Diff
`@firebase/logger`	?	`LogLevel` `Logger`	?
`@firebase/util`	?	`ErrorFactory` `isIndexedDBAvailable` `validateIndexedDBOpenable`	?
`@firebase/app-exp`	?	`_registerComponent` `registerVersion`	?
`@firebase/component`	?	`Component`	?

Test Logs

Head (c79740d7): https://github.com/firebase/firebase-js-sdk/actions/runs/272193288

hsubox76

LG, by the way

I notice in the design doc the signature is given as firebase.functions(region) but it should be firebase.functions(app, region)
But it looks like that is not documented and in fact there is currently a bug where setting region doesn't work through firebase.functions(app, region) but only through
```
const app = firebase.initializeApp({...});
app.functions(region);
```
So we will fix that separately.

samtstern · 2020-09-25T16:07:09Z

@hsubox76 says I can ignore the test.

LanderBeeuwsaert · 2020-09-28T07:30:00Z

Hello @samtstern, a question we have about this PR:
is this related to https://firebase.google.com/docs/hosting/functions#create_an_http_function_to_your_hosting_site ?
Because we actually wanted to use this possibility in our application to make it easier for clients to interact with our functions, however it is until now only possible to use this in the US region.
Will this change make it possible to use in functions deployed in Europe as well?
Or am I totally off topic here?

samtstern · 2020-09-28T08:09:12Z

@LanderBeeuwsaert no this won't really change that. You could already use callable functions in your app from any region. This is about allowing you to use functions redirects with Callable Functions.

So if your callable function (still in us-central1) is called fooBar you could call it from https://mydomain.com/fooBar. The main advantage of this is that it reduces lock-in. If one day you want to leave Cloud Functions and move to say, Cloud Run or Google Compute Engine, your client side code would not have to know about it.

LanderBeeuwsaert · 2020-09-28T08:50:15Z

@samtstern What I seem to understand out of your response is that this PR enables the possibility for functions redirects , but only still for us-central1. Correct?
Are there any plans to enable this sort of redirect for functions deployed in other regions (e.g. europe-west3)?

samtstern · 2020-09-28T09:18:13Z

@LanderBeeuwsaert we'd like to enable redirects to other regions one day but that won't require any changes in the JS SDK! That's a Hosting backend change.

LanderBeeuwsaert · 2020-09-28T09:20:08Z

top, thanks for the quick response!

Add custom domain support to callable functions

3ee0f22

samtstern requested review from Feiyang1, hiranya911 and hsubox76 as code owners September 22, 2020 14:43

hsubox76 reviewed Sep 22, 2020

View reviewed changes

samtstern added 4 commits September 24, 2020 13:00

Implement functions-exp

75b9e4e

Merge remote-tracking branch 'github/master' into ss-functions-custom…

0283167

…-domain

Prettier

4df34d9

Add changeset

f61ba5a

samtstern requested a review from hsubox76 September 24, 2020 12:02

hsubox76 reviewed Sep 24, 2020

View reviewed changes

Code review

05e6e0a

samtstern requested a review from hsubox76 September 25, 2020 09:54

hsubox76 approved these changes Sep 25, 2020

View reviewed changes

samtstern merged commit a6af7c2 into master Sep 25, 2020

samtstern added a commit that referenced this pull request Sep 28, 2020

Amend changeset for PR #3825

74ed4c2

samtstern mentioned this pull request Sep 28, 2020

Amend changeset for PR #3825 #3851

Merged

Feiyang1 pushed a commit that referenced this pull request Sep 28, 2020

Amend changeset for PR #3825 (#3851)

01bb65b

google-oss-bot mentioned this pull request Sep 29, 2020

Version Packages #3863

Merged

samtstern mentioned this pull request Oct 20, 2020

Add custom domain support to callable functions firebase/firebase-ios-sdk#6787

Merged

kroikie mentioned this pull request Oct 24, 2020

Add custom domain support to callable functions firebase/firebase-android-sdk#2100

Merged

firebase locked and limited conversation to collaborators Oct 26, 2020

Add custom domain support to callable functions #3825

Add custom domain support to callable functions #3825

Conversation

samtstern commented Sep 22, 2020

Discussion

Testing

API Changes

changeset-bot bot commented Sep 22, 2020 • edited Loading

🦋 Changeset detected

google-oss-bot commented Sep 22, 2020 • edited Loading

Binary Size Report

Affected SDKs

@firebase/firestore

@firebase/firestore/exp

@firebase/firestore/lite

@firebase/firestore/memory

@firebase/functions

firebase

Test Logs

hsubox76 left a comment

Choose a reason for hiding this comment

samtstern commented Sep 24, 2020

github-actions bot commented Sep 24, 2020

Changeset File Check ⚠️

hsubox76 Sep 24, 2020

Choose a reason for hiding this comment

samtstern Sep 25, 2020

Choose a reason for hiding this comment

google-oss-bot commented Sep 25, 2020

Size Analysis Report

Affected Products

@firebase/app-exp

SDK_VERSION

Size

Dependencies

External Dependencies

_DEFAULT_ENTRY_NAME

Size

Dependencies

External Dependencies

_addComponent

Size

Dependencies

External Dependencies

_addOrOverwriteComponent

Size

Dependencies

External Dependencies

_apps

Size

Dependencies

External Dependencies

_clearComponents

Size

Dependencies

External Dependencies

_components

Size

Dependencies

External Dependencies

_getProvider

Size

Dependencies

External Dependencies

_registerComponent

Size

Dependencies

External Dependencies

_removeServiceInstance

Size

Dependencies

External Dependencies

deleteApp

Size

Dependencies

External Dependencies

getApp

Size

Dependencies

External Dependencies

changeset-bot bot commented Sep 22, 2020 •

edited

Loading

google-oss-bot commented Sep 22, 2020 •

edited

Loading

`@firebase/firestore`

`@firebase/firestore/exp`

`@firebase/firestore/lite`

`@firebase/firestore/memory`

`@firebase/functions`

`firebase`

`@firebase/app-exp`

`SDK_VERSION`

`_DEFAULT_ENTRY_NAME`

`_addComponent`

`_addOrOverwriteComponent`

`_apps`

`_clearComponents`

`_components`

`_getProvider`

`_registerComponent`

`_removeServiceInstance`

`deleteApp`

`getApp`

`getApps`

`initializeApp`

`onLog`

`registerVersion`

`setLogLevel`

`@firebase/functions-exp`

`getFunctions`

`httpsCallable`

`useFunctionsEmulator`

`@firebase/installations-exp`

`deleteInstallations`

`getId`

`getInstallations`

`getToken`

`onIdChange`

`@firebase/performance-exp`

`getPerformance`

`registerPerformance`

`trace`