Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for performance-exp #3855

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Fixes for performance-exp #3855

merged 1 commit into from
Sep 28, 2020

Conversation

jposuna
Copy link
Contributor

@jposuna jposuna commented Sep 28, 2020

  • Importing installations in performance-exp/index.ts
  • Fixing the location of the typings in firebase-exp/performance

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2020

⚠️ No Changeset found

Latest commit: 14713c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (7c1c7f1) and head commit (b6ae17e).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

@firebase/performance-exp

  • getPerformance

    Size

    Type Base (7c1c7f1) Head (b6ae17e) Diff
    size 16.8 kB 16.8 kB +36 B (+0.2%)
    size_with_ext_deps 21.8 kB 33.8 kB +12.0 kB (+54.9%)
  • registerPerformance

    Size

    Type Base (7c1c7f1) Head (b6ae17e) Diff
    size 16.7 kB 16.7 kB +36 B (+0.2%)
    size_with_ext_deps 21.7 kB 33.7 kB +12.1 kB (+55.6%)
  • trace

    Size

    Type Base (7c1c7f1) Head (b6ae17e) Diff
    size 16.7 kB 16.7 kB +36 B (+0.2%)
    size_with_ext_deps 21.7 kB 33.8 kB +12.1 kB (+55.5%)

Test Logs

@jposuna jposuna merged commit 7d655a8 into master Sep 28, 2020
@firebase firebase locked and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants