Remove null and NaN checks in filters #3960
Conversation
🦋 Changeset detectedLatest commit: efd4ed1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs
|
Size Analysis ReportAffected ProductsNo changes between base commit (4b540f9) and head commit (038dc2c). Test Logs
|
thebrianchen
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
.changeset/wicked-cups-search.md
Outdated
| '@firebase/firestore': minor | ||
| --- | ||
|
|
||
| Removed validation of `null` and `NaN` values in filters. However, note that only `==` and `!=` filters match against `null` and `NaN`. |
There was a problem hiding this comment.
However, note that only
==and!=filters match againstnullandNaN.
This reads to me in a way that suggests we're removing guard rails but still expecting users to remember this. I'd suggest something more like this:
Removed excess validation of
nullandNaNvalues in query filters. This more closely aligns the SDK with the Firestore backend, which has always acceptednullandNaNfor all operators, even though this isn't necessarily useful.
| @@ -800,6 +813,14 @@ apiDescribe('Queries', (persistence: boolean) => { | |||
| // With objects. | |||
| const snapshot2 = await coll.where('zip', 'in', [{ code: 500 }]).get(); | |||
| expect(toDataArray(snapshot2)).to.deep.equal([{ zip: { code: 500 } }]); | |||
|
|
|||
| // With null. | |||
| const snapshot3 = await coll.where('zip', 'in', [null]).get(); | |||
There was a problem hiding this comment.
Do we need a test that shows that "in" with null/nan and something else still finds the something else?
|
|
||
| // With null. | ||
| const snapshot3 = await coll | ||
| .where('zip', 'array-contains-any', [null]) |
There was a problem hiding this comment.
Do we need a test that shows that "array-contains-any" with null/nan and something else still finds the something else?
No description provided.