Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTDB get shouldn't send requests for listened-to data #4299

Merged
merged 3 commits into from
Jan 20, 2021

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Jan 15, 2021

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2021

🦋 Changeset detected

Latest commit: 76930b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@firebase/database Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 15, 2021

Size Analysis Report

Affected Products

No changes between base commit (02dcd92) and head commit (7bfb0cb).

@schmidt-sebastian
Copy link
Contributor

https://b.corp.google.com/issues/177263312

FYI - we usually don't post links to Corp on GitHub, since they error our for external users. I usually just post b/xxxxxx or go/ links.

.changeset/hip-turtles-travel.md Outdated Show resolved Hide resolved
packages/database/src/core/Repo.ts Show resolved Hide resolved
@jmwski jmwski merged commit 04a0fea into master Jan 20, 2021
@jmwski jmwski deleted the jw/get-improvement branch January 20, 2021 22:55
@google-oss-bot google-oss-bot mentioned this pull request Jan 26, 2021
@firebase firebase locked and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants