Modify URL parsing for React Native compat. #4543

yuchenshi · 2021-02-26T02:10:15Z

I've tried to keep the regex short and to the point, but let's see.

Once this is merged, there should be no new URL or new URLSearchParams floating in auth-exp.

changeset-bot · 2021-02-26T02:10:17Z

⚠️ No Changeset found

Latest commit: 03aaa51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2021-02-26T02:26:47Z

Binary Size Report

Affected SDKs

`@firebase/firestore`

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
browser	259 kB	259 kB	-111 B (-0.0%)
esm2017	202 kB	201 kB	-107 B (-0.1%)
main	530 kB	530 kB	-187 B (-0.0%)
module	259 kB	259 kB	-111 B (-0.0%)
react-native	202 kB	201 kB	-107 B (-0.1%)

`@firebase/firestore-exp`

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
browser	199 kB	199 kB	-107 B (-0.1%)
main	505 kB	505 kB	-187 B (-0.0%)
module	199 kB	199 kB	-107 B (-0.1%)
react-native	200 kB	200 kB	-107 B (-0.1%)

`@firebase/firestore/bundle`

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
browser	266 kB	266 kB	-111 B (-0.0%)
esm2017	155 kB	155 kB	-107 B (-0.1%)
main	526 kB	526 kB	-187 B (-0.0%)
module	266 kB	266 kB	-111 B (-0.0%)
react-native	155 kB	155 kB	-107 B (-0.1%)

`@firebase/firestore/memory`

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
browser	196 kB	196 kB	-111 B (-0.1%)
esm2017	152 kB	152 kB	-107 B (-0.1%)
main	324 kB	324 kB	-187 B (-0.1%)
module	196 kB	196 kB	-111 B (-0.1%)
react-native	152 kB	152 kB	-107 B (-0.1%)

`@firebase/firestore/memory-bundle`

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
browser	205 kB	204 kB	-111 B (-0.1%)
esm2017	155 kB	155 kB	-107 B (-0.1%)
main	321 kB	321 kB	-187 B (-0.1%)
module	205 kB	204 kB	-111 B (-0.1%)
react-native	155 kB	155 kB	-107 B (-0.1%)

`@firebase/util`

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
browser	20.2 kB	20.5 kB	+285 B (+1.4%)
esm2017	19.0 kB	19.2 kB	+275 B (+1.4%)
main	24.4 kB	24.8 kB	+393 B (+1.6%)
module	20.2 kB	20.5 kB	+285 B (+1.4%)

`firebase`

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
firebase-firestore.js	304 kB	303 kB	-117 B (-0.0%)
firebase-firestore.memory.js	243 kB	243 kB	-117 B (-0.0%)
firebase.js	845 kB	845 kB	-117 B (-0.0%)

Test Logs

Base (04e53223): https://github.com/firebase/firebase-js-sdk/actions/runs/601750154
Head (8d545cd9): https://github.com/firebase/firebase-js-sdk/actions/runs/603923631

packages-exp/auth-exp/src/core/auth/emulator.ts

google-oss-bot · 2021-02-26T17:29:36Z

Size Analysis Report

Affected Products

`@firebase/auth-exp`

`ActionCodeURL`

Size Table

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
size	29.0 kB	29.0 kB	+73 B (+0.3%)
size-with-ext-deps	39.7 kB	40.0 kB	+311 B (+0.8%)

External Dependency Table

Module Base (04e5322) Head (8d545cd) Diff

@firebase/util

ErrorFactory
FirebaseError
base64Decode
createSubscribe
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring

11 dependencies

ErrorFactory
FirebaseError
base64Decode
createSubscribe
extractQuerystring
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring
querystringDecode

+ extractQuerystring
+ querystringDecode

`EmailAuthProvider`

Size Table

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
size	31.3 kB	31.4 kB	+70 B (+0.2%)
size-with-ext-deps	42.1 kB	42.4 kB	+311 B (+0.7%)

External Dependency Table

Module Base (04e5322) Head (8d545cd) Diff

@firebase/util

ErrorFactory
FirebaseError
base64Decode
createSubscribe
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring

11 dependencies

ErrorFactory
FirebaseError
base64Decode
createSubscribe
extractQuerystring
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring
querystringDecode

+ extractQuerystring
+ querystringDecode

getAuth
Size Table
Type Base (04e5322) Head (8d545cd) Diff
size
55.7 kB
55.7 kB
-21 B (-0.0%)
size-with-ext-deps
66.7 kB
66.7 kB
-21 B (-0.0%)

`isSignInWithEmailLink`

Size Table

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
size	29.1 kB	29.1 kB	+73 B (+0.3%)
size-with-ext-deps	39.8 kB	40.2 kB	+311 B (+0.8%)

External Dependency Table

Module Base (04e5322) Head (8d545cd) Diff

@firebase/util

ErrorFactory
FirebaseError
base64Decode
createSubscribe
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring

11 dependencies

ErrorFactory
FirebaseError
base64Decode
createSubscribe
extractQuerystring
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring
querystringDecode

+ extractQuerystring
+ querystringDecode

`parseActionCodeURL`

Size Table

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
size	29.0 kB	29.1 kB	+73 B (+0.3%)
size-with-ext-deps	39.8 kB	40.1 kB	+311 B (+0.8%)

External Dependency Table

Module Base (04e5322) Head (8d545cd) Diff

@firebase/util

ErrorFactory
FirebaseError
base64Decode
createSubscribe
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring

11 dependencies

ErrorFactory
FirebaseError
base64Decode
createSubscribe
extractQuerystring
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring
querystringDecode

+ extractQuerystring
+ querystringDecode

`signInWithEmailAndPassword`

Size Table

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
size	32.8 kB	32.9 kB	+70 B (+0.2%)
size-with-ext-deps	43.6 kB	43.9 kB	+311 B (+0.7%)

External Dependency Table

Module Base (04e5322) Head (8d545cd) Diff

@firebase/util

ErrorFactory
FirebaseError
base64Decode
createSubscribe
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring

11 dependencies

ErrorFactory
FirebaseError
base64Decode
createSubscribe
extractQuerystring
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring
querystringDecode

+ extractQuerystring
+ querystringDecode

`signInWithEmailLink`

Size Table

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
size	33.0 kB	33.0 kB	+69 B (+0.2%)
size-with-ext-deps	43.8 kB	44.1 kB	+311 B (+0.7%)

External Dependency Table

Module Base (04e5322) Head (8d545cd) Diff

@firebase/util

ErrorFactory
FirebaseError
base64Decode
createSubscribe
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring

11 dependencies

ErrorFactory
FirebaseError
base64Decode
createSubscribe
extractQuerystring
getUA
isBrowserExtension
isMobileCordova
isReactNative
querystring
querystringDecode

+ extractQuerystring
+ querystringDecode

`useAuthEmulator`

Size Table

Type	Base (`04e5322`)	Head (`8d545cd`)	Diff
size	29.2 kB	29.7 kB	+471 B (+1.6%)
size-with-ext-deps	40.0 kB	40.5 kB	+471 B (+1.2%)

Dependency Table

Type Base (04e5322) Head (8d545cd) Diff

functions

48 dependencies

_assert
_castAuth
_createError
_emulatorUrl
_fail
_getBrowserName
_getClientVersion
_getCurrentScheme
_getFinalTarget
_getInstance
_getUserLanguage
_isAndroid
_isBlackBerry
_isChromeIOS
_isFirefox
_isHttpOrHttps
_isIEMobile
_isOnline
_isSafari
_isWebOS
_logError
_logoutIfInvalidated
_parseToken
_performApiRequest
_performFetchWithErrorHandling
_persistenceKeyName
_prodErrorMap
_reloadWithoutSaving
_tokenExpiresIn
assertStringOrUndefined
createErrorInternal
debugAssert
debugFail
deleteAccount
emitEmulatorWarning
extractProviderData
getAccountInfo
getIdTokenResult
getVersionForPlatform
isUserInvalidated
makeTaggedError
mergeProviderData
registerAuth
reload
requestStsToken
secondsStringToMilliseconds
useAuthEmulator
utcTimestampToDateString

<full-list-too-large-to-display>
<see-test-logs-below-for-details>

+ extractHostAndPort
+ extractProtocol
+ parsePort

browserPopupRedirectResolver
Size Table
Type Base (04e5322) Head (8d545cd) Diff
size
45.4 kB
45.3 kB
-21 B (-0.0%)
size-with-ext-deps
56.3 kB
56.2 kB
-21 B (-0.0%)

Test Logs

Feiyang1 · 2021-02-26T20:04:33Z

Please fix lint errors.

yuchenshi requested a review from sam-gc February 26, 2021 02:10

yuchenshi assigned sam-gc Feb 26, 2021

yuchenshi requested review from avolkovi, Feiyang1, hiranya911 and hsubox76 as code owners February 26, 2021 02:10

Modify URL parsing for React Native compat.

f02289a

yuchenshi force-pushed the ys/auth-exp-react-native branch from 710e317 to f02289a Compare February 26, 2021 17:06

sam-gc reviewed Feb 26, 2021

View reviewed changes

packages-exp/auth-exp/src/core/auth/emulator.ts Show resolved Hide resolved

packages-exp/auth-exp/src/core/auth/emulator.ts Show resolved Hide resolved

yuchenshi requested a review from sam-gc February 26, 2021 18:07

sam-gc approved these changes Feb 26, 2021

View reviewed changes

yuchenshi assigned Feiyang1 and unassigned sam-gc Feb 26, 2021

Feiyang1 approved these changes Feb 26, 2021

View reviewed changes

Feiyang1 assigned yuchenshi and unassigned Feiyang1 Feb 26, 2021

Remove unused import.

03aaa51

yuchenshi merged commit 5019599 into master Feb 27, 2021

yuchenshi deleted the ys/auth-exp-react-native branch February 27, 2021 00:28

Feiyang1 mentioned this pull request Mar 10, 2021

add the missing changeset for @firebase/util #4610

Merged

firebase locked and limited conversation to collaborators Mar 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify URL parsing for React Native compat. #4543

Modify URL parsing for React Native compat. #4543

yuchenshi commented Feb 26, 2021

changeset-bot bot commented Feb 26, 2021 •

edited

Loading

google-oss-bot commented Feb 26, 2021 •

edited

Loading

`@firebase/firestore`

`@firebase/firestore-exp`

`@firebase/firestore/bundle`

`@firebase/firestore/memory`

`@firebase/firestore/memory-bundle`

`@firebase/util`

`firebase`

google-oss-bot commented Feb 26, 2021 •

edited

Loading

Affected Products

`@firebase/auth-exp`

`ActionCodeURL`

`EmailAuthProvider`

`getAuth`

`isSignInWithEmailLink`

`parseActionCodeURL`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`useAuthEmulator`

`browserPopupRedirectResolver`

Test Logs

Feiyang1 commented Feb 26, 2021

Modify URL parsing for React Native compat. #4543

Modify URL parsing for React Native compat. #4543

Conversation

yuchenshi commented Feb 26, 2021

changeset-bot bot commented Feb 26, 2021 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Feb 26, 2021 • edited Loading

Binary Size Report

Affected SDKs

@firebase/firestore

@firebase/firestore-exp

@firebase/firestore/bundle

@firebase/firestore/memory

@firebase/firestore/memory-bundle

@firebase/util

firebase

Test Logs

google-oss-bot commented Feb 26, 2021 • edited Loading

Size Analysis Report

Affected Products

@firebase/auth-exp

ActionCodeURL

EmailAuthProvider

getAuth

isSignInWithEmailLink

parseActionCodeURL

signInWithEmailAndPassword

signInWithEmailLink

useAuthEmulator

browserPopupRedirectResolver

Test Logs

Feiyang1 commented Feb 26, 2021

changeset-bot bot commented Feb 26, 2021 •

edited

Loading

google-oss-bot commented Feb 26, 2021 •

edited

Loading

`@firebase/firestore`

`@firebase/firestore-exp`

`@firebase/firestore/bundle`

`@firebase/firestore/memory`

`@firebase/firestore/memory-bundle`

`@firebase/util`

`firebase`

google-oss-bot commented Feb 26, 2021 •

edited

Loading

`@firebase/auth-exp`

`ActionCodeURL`

`EmailAuthProvider`

`getAuth`

`isSignInWithEmailLink`

`parseActionCodeURL`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`useAuthEmulator`

`browserPopupRedirectResolver`