Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RTDB build #4777

Merged
merged 2 commits into from
Apr 13, 2021
Merged

fix RTDB build #4777

merged 2 commits into from
Apr 13, 2021

Conversation

Feiyang1
Copy link
Member

Addresses #4776

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2021

🦋 Changeset detected

Latest commit: e975964

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@firebase/database Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (3a18640) Head (7e344d9) Diff
    browser 292 kB 291 kB -494 B (-0.2%)
    esm2017 262 kB 261 kB -484 B (-0.2%)
    main 294 kB 294 kB -470 B (-0.2%)
    module 292 kB 291 kB -494 B (-0.2%)
  • firebase

    Type Base (3a18640) Head (7e344d9) Diff
    firebase-database.js 188 kB 183 kB -4.38 kB (-2.3%)
    firebase.js 873 kB 869 kB -4.37 kB (-0.5%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 13, 2021

Size Analysis Report

Affected Products

Diffs between base commit (3a18640) and head commit (20c445e) are too large (479,509 characters) to display.

Please check below links to see details from the original test log.

@Feiyang1 Feiyang1 merged commit 74fa506 into master Apr 13, 2021
@Feiyang1 Feiyang1 deleted the fei-fix-rtdb-build branch April 13, 2021 04:12
@google-oss-bot google-oss-bot mentioned this pull request Apr 13, 2021
@firebase firebase locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants