Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send empty GMPID header #4810

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Don't send empty GMPID header #4810

merged 2 commits into from
Apr 21, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Apr 20, 2021

Fixes #4795.

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2021

🦋 Changeset detected

Latest commit: 4a749de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 21, 2021

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (364e336) Head (b33beb6) Diff
    esm2017 ? 18.7 kB ? (?)
    main ? 24.2 kB ? (?)
    module ? 23.4 kB ? (?)
  • @firebase/app

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 10.8 kB ? (?)
    esm2017 ? 9.57 kB ? (?)
    lite ? 8.88 kB ? (?)
    lite-esm2017 ? 7.87 kB ? (?)
    main ? 9.93 kB ? (?)
    module ? 10.8 kB ? (?)
    react-native ? 9.64 kB ? (?)
  • @firebase/auth

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 181 kB ? (?)
    main ? 181 kB ? (?)
    module ? 181 kB ? (?)
  • @firebase/component

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 7.24 kB ? (?)
    esm2017 ? 5.55 kB ? (?)
    main ? 7.57 kB ? (?)
    module ? 7.24 kB ? (?)
  • @firebase/database

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 291 kB ? (?)
    esm2017 ? 261 kB ? (?)
    main ? 294 kB ? (?)
    module ? 291 kB ? (?)
  • @firebase/database-compat

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 84.3 kB ? (?)
    main ? 99.7 kB ? (?)
    module ? 84.3 kB ? (?)
  • @firebase/database-exp

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 242 kB ? (?)
    main ? 273 kB ? (?)
    module ? 242 kB ? (?)
  • @firebase/firestore

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 283 kB ? (?)
    esm2017 ? 225 kB ? (?)
    main ? 529 kB ? (?)
    module ? 283 kB ? (?)
    react-native ? 225 kB ? (?)
  • @firebase/firestore-compat

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 28.4 kB ? (?)
    main ? 37.4 kB ? (?)
    module ? 28.4 kB ? (?)
    react-native ? 28.1 kB ? (?)
  • @firebase/firestore-exp

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 223 kB ? (?)
    main ? 505 kB ? (?)
    module ? 223 kB ? (?)
    react-native ? 223 kB ? (?)
  • @firebase/firestore-lite

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 71.4 kB ? (?)
    main ? 145 kB ? (?)
    module ? 71.4 kB ? (?)
    react-native ? 71.6 kB ? (?)
  • @firebase/firestore/bundle

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 289 kB ? (?)
    esm2017 ? 175 kB ? (?)
    main ? 525 kB ? (?)
    module ? 289 kB ? (?)
    react-native ? 175 kB ? (?)
  • @firebase/firestore/memory

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 215 kB ? (?)
    esm2017 ? 171 kB ? (?)
    main ? 323 kB ? (?)
    module ? 215 kB ? (?)
    react-native ? 171 kB ? (?)
  • @firebase/firestore/memory-bundle

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 223 kB ? (?)
    esm2017 ? 175 kB ? (?)
    main ? 320 kB ? (?)
    module ? 223 kB ? (?)
    react-native ? 175 kB ? (?)
  • @firebase/functions

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 9.90 kB ? (?)
    esm2017 ? 7.71 kB ? (?)
    main ? 10.3 kB ? (?)
    module ? 9.90 kB ? (?)
  • @firebase/installations

    Type Base (364e336) Head (b33beb6) Diff
    esm2017 ? 16.6 kB ? (?)
    main ? 22.2 kB ? (?)
    module ? 21.6 kB ? (?)
  • @firebase/logger

    Type Base (364e336) Head (b33beb6) Diff
    esm2017 ? 3.25 kB ? (?)
    main ? 5.38 kB ? (?)
    module ? 4.65 kB ? (?)
  • @firebase/messaging

    Type Base (364e336) Head (b33beb6) Diff
    esm2017 ? 26.2 kB ? (?)
    main ? 34.9 kB ? (?)
    module ? 34.4 kB ? (?)
  • @firebase/performance

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 27.7 kB ? (?)
    esm2017 ? 25.9 kB ? (?)
    main ? 28.0 kB ? (?)
    module ? 27.7 kB ? (?)
  • @firebase/polyfill

    Type Base (364e336) Head (b33beb6) Diff
    main ? 747 B ? (?)
    module ? 705 B ? (?)
  • @firebase/remote-config

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 22.4 kB ? (?)
    esm2017 ? 17.4 kB ? (?)
    main ? 23.0 kB ? (?)
    module ? 22.4 kB ? (?)
  • @firebase/rules-unit-testing

    Type Base (364e336) Head (b33beb6) Diff
    main ? 12.6 kB ? (?)
  • @firebase/storage

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 62.0 kB ? (?)
    esm2017 ? 53.6 kB ? (?)
    main ? 62.4 kB ? (?)
    module ? 62.0 kB ? (?)
  • @firebase/storage-compat

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 10.2 kB ? (?)
    main ? 28.0 kB ? (?)
    module ? 10.2 kB ? (?)
  • @firebase/storage-exp

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 50.6 kB ? (?)
    main ? 51.6 kB ? (?)
    module ? 50.6 kB ? (?)
  • @firebase/util

    Type Base (364e336) Head (b33beb6) Diff
    browser ? 20.2 kB ? (?)
    esm2017 ? 19.0 kB ? (?)
    main ? 24.6 kB ? (?)
    module ? 20.2 kB ? (?)
  • @firebase/webchannel-wrapper

    Type Base (364e336) Head (b33beb6) Diff
    esm2017 ? 39.5 kB ? (?)
    main ? 46.9 kB ? (?)
    module ? 40.8 kB ? (?)
  • firebase

    Click to show 15 binary size changes.
    Type Base (364e336) Head (b33beb6) Diff
    firebase-analytics.js ? 35.8 kB ? (?)
    firebase-app.js ? 21.2 kB ? (?)
    firebase-auth.js ? 177 kB ? (?)
    firebase-database.js ? 183 kB ? (?)
    firebase-firestore.js ? 327 kB ? (?)
    firebase-firestore.memory.js ? 262 kB ? (?)
    firebase-functions.js ? 10.3 kB ? (?)
    firebase-installations.js ? 19.3 kB ? (?)
    firebase-messaging.js ? 41.0 kB ? (?)
    firebase-performance-standalone.es2017.js ? 72.9 kB ? (?)
    firebase-performance-standalone.js ? 49.2 kB ? (?)
    firebase-performance.js ? 38.3 kB ? (?)
    firebase-remote-config.js ? 36.9 kB ? (?)
    firebase-storage.js ? 40.7 kB ? (?)
    firebase.js ? 869 kB ? (?)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

Diffs between base commit (364e336) and head commit (1287ce0) are too large (479,509 characters) to display.

Please check below links to see details from the original test log.

@Feiyang1 Feiyang1 merged commit c658836 into master Apr 21, 2021
@Feiyang1 Feiyang1 deleted the mrschmidt/noemptyappid branch April 21, 2021 18:24
@google-oss-bot google-oss-bot mentioned this pull request Apr 21, 2021
@firebase firebase locked and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request.auth is null for what should be a valid request with self-made custom token [Firestore emulation]
5 participants