-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mockUserToken support for Firestore Emulator. #4837
Conversation
🦋 Changeset detectedLatest commit: ec61867 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment has been minimized.
This comment has been minimized.
ead9cea
to
ca4c905
Compare
8eaffd0
to
e3b316c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix #4715, does it mean developers need to rewrite their code to use firestore APIs directly:
const firestore = getFirestore();
useFirestoreEmulator(..., {mockUserToken});
instead of relying on @firebase/rules-unit-testing
to create a firestore instance configured with emulator ?
What is the plan to update @firebase/rules-unit-testing
the library itself and the documentation?
Yes.
See http://go/firebase-rules-unit-testing-next (Googlers only). Timeline section has the remaining action items tracked. |
25b76f4
to
58f8148
Compare
Binary Size ReportAffected SDKs
Test Logs
|
Co-authored-by: Feiyang <feiyangc@google.com>
4e620b0
to
ec61867
Compare
The Firestore version of #4792.
See tests added. Also manually tested end-to-end with modified security rules quickstart.
Fixes #4715.