Fix the import of node-fetch polyfill #5399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage and FirestoreLite were importing node-fetch as a namespace, rather than pulling the default fetch function and using that.
This was leading to timeouts in Storage node and uncaught exceptions in Firestore Lite
@firebase/firestore: Firestore (9.0.0_lite): RPC_ERROR HTTP error has no status
diving in and setting a breakpoint I found this underlying errorTypeError: this.fetchImpl is not a function