Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the implementation of collection() with multiple path segments. #5440

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Fix the implementation of collection() with multiple path segments. #5440

merged 2 commits into from
Sep 8, 2021

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Sep 3, 2021 •
edited by schmidt-sebastian
Loading

Fixes #5431

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: e12545c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ehsannas
Copy link
Contributor Author

ehsannas commented Sep 3, 2021

This should address #5431

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@ehsannas ehsannas merged commit bf5772f into master Sep 8, 2021
@ehsannas ehsannas deleted the ehsann/fix-collection-path-segments branch September 8, 2021 14:41
@google-oss-bot google-oss-bot mentioned this pull request Sep 8, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@ehsannas ehsannas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firebase v9 create collection refference from collection refference path order error
2 participants
@ehsannas @schmidt-sebastian