Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export types from @firebase/database-compat for admin SDK #5531

Merged
merged 3 commits into from
Sep 22, 2021
Merged

export types from @firebase/database-compat for admin SDK #5531

merged 3 commits into from
Sep 22, 2021

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: c3a7c4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/database-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2021 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

hiranya911
hiranya911 approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We only need the Database type from the v8 @firebase/database package. But exporting everything from here seems consistent and more future-proof.

@Feiyang1
Copy link
Member Author

I see ServerValue being used as a value as well.

@hiranya911
Copy link
Contributor

I see ServerValue being used as a value as well.

Yes! Our database/index file does so. You're right.

@Feiyang1 Feiyang1 merged commit b79bd33 into master Sep 22, 2021
@Feiyang1 Feiyang1 deleted the fei-database-admin branch September 22, 2021 20:23
@google-oss-bot google-oss-bot mentioned this pull request Sep 22, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

@jsdt jsdt Awaiting requested review from jsdt

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Feiyang1 @hiranya911