Add repository fields to some compat packages and add workflow trigger for canary #5587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
requested review from
Feiyang1,
hiranya911,
jsdt and
schmidt-sebastian
as code owners
🦋 Changeset detectedLatest commit: 86e999c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Binary Size ReportAffected SDKsNo changes between base commit (53a9263) and head commit (69539eb). Test Logs
|
Size Analysis Report |
Feiyang1
approved these changes
Oct 11, 2021
Feiyang1
reviewed
Oct 11, 2021
| @@ -4,6 +4,7 @@ on: | |||
| push: | |||
| branches: | |||
| - master | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
Is it okay to have a colon with an empty body?
There was a problem hiding this comment.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
database-compat,firestore-compat, andstorage-compatwere missingrepositoryfields, which wombat-dressing-room uses to determine if we have permission to publish. This breaks canary and prerelease workflows, which use wombat-dressing room to publish packages.I've also added a workflow_dispatch trigger to the canary workflow to make it easier to manually trigger a canary build in the future for debugging or other reasons.