Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report build variants for packages #5596

Merged
merged 15 commits into from
Oct 12, 2021
Merged

report build variants for packages #5596

merged 15 commits into from
Oct 12, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Oct 8, 2021

  • report build variants, e.g. esm5, esm2017, cjs5, cjs2017 etc.
  • add missing runtime (node vs browser) report for a few packages which have isomorphic implementation for Node and browser
  • add missing reporting for FCM which doesn't report at all at the moment.

@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 9facaf8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@firebase/analytics Patch
@firebase/app Patch
@firebase/auth Patch
@firebase/database Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/installations Patch
@firebase/messaging Patch
@firebase/performance Patch
@firebase/remote-config Patch
@firebase/storage Patch
@firebase/analytics-compat Patch
firebase Patch
@firebase/app-compat Patch
@firebase/auth-compat Patch
@firebase/database-compat Patch
@firebase/firestore-compat Patch
@firebase/functions-compat Patch
@firebase/installations-compat Patch
@firebase/messaging-compat Patch
@firebase/performance-compat Patch
@firebase/remote-config-compat Patch
@firebase/storage-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 8, 2021
hsubox76
hsubox76 approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG except some lint and indent issues.

packages/auth/rollup.config.js Show resolved Hide resolved
packages/functions/src/index.node.ts Show resolved Hide resolved
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (352cc26) Head (bf11e91) Diff
    browser 18.9 kB 18.9 kB +40 B (+0.2%)
    esm5 23.5 kB 23.5 kB +37 B (+0.2%)
    main 24.6 kB 24.6 kB +41 B (+0.2%)
    module 18.9 kB 18.9 kB +40 B (+0.2%)

  • @firebase/app

    Type Base (352cc26) Head (bf11e91) Diff
    browser 7.69 kB 7.74 kB +46 B (+0.6%)
    esm5 9.32 kB 9.37 kB +43 B (+0.5%)
    main 10.2 kB 10.2 kB +47 B (+0.5%)
    module 7.69 kB 7.74 kB +46 B (+0.6%)

  • @firebase/auth/cordova

    Type Base (352cc26) Head (bf11e91) Diff
    browser 178 kB 178 kB +37 B (+0.0%)
    module 178 kB 178 kB +37 B (+0.0%)

  • @firebase/auth/internal

    Type Base (352cc26) Head (bf11e91) Diff
    browser 163 kB 163 kB +40 B (+0.0%)
    esm5 211 kB 211 kB +37 B (+0.0%)
    main 178 kB 178 kB +43 B (+0.0%)
    module 163 kB 163 kB +40 B (+0.0%)

  • @firebase/auth/react-native

    Type Base (352cc26) Head (bf11e91) Diff
    browser 143 kB 143 kB +43 B (+0.0%)
    module 143 kB 143 kB +43 B (+0.0%)

  • @firebase/database

    Type Base (352cc26) Head (bf11e91) Diff
    browser 247 kB 247 kB +40 B (+0.0%)
    esm5 275 kB 275 kB +37 B (+0.0%)
    main 280 kB 280 kB +41 B (+0.0%)
    module 247 kB 247 kB +40 B (+0.0%)

  • @firebase/firestore

    Type Base (352cc26) Head (bf11e91) Diff
    browser 225 kB 225 kB +50 B (+0.0%)
    esm5 282 kB 282 kB +40 B (+0.0%)
    main 512 kB 512 kB +46 B (+0.0%)
    module 225 kB 225 kB +50 B (+0.0%)
    react-native 225 kB 225 kB +49 B (+0.0%)

  • @firebase/firestore-lite

    Type Base (352cc26) Head (bf11e91) Diff
    browser 71.6 kB 71.6 kB +48 B (+0.1%)
    esm5 84.7 kB 84.8 kB +45 B (+0.1%)
    main 147 kB 147 kB +55 B (+0.0%)
    module 71.6 kB 71.6 kB +48 B (+0.1%)
    react-native 71.8 kB 71.8 kB +50 B (+0.1%)

  • @firebase/functions

    Type Base (352cc26) Head (bf11e91) Diff
    browser 8.79 kB 8.85 kB +56 B (+0.6%)
    esm5 10.9 kB 10.9 kB +53 B (+0.5%)
    main 11.6 kB 11.7 kB +57 B (+0.5%)
    module 8.79 kB 8.85 kB +56 B (+0.6%)

  • @firebase/installations

    Type Base (352cc26) Head (bf11e91) Diff
    browser 17.2 kB 17.3 kB +40 B (+0.2%)
    esm5 22.3 kB 22.3 kB +37 B (+0.2%)
    main 23.1 kB 23.1 kB +41 B (+0.2%)
    module 17.2 kB 17.3 kB +40 B (+0.2%)

  • @firebase/messaging

    Type Base (352cc26) Head (bf11e91) Diff
    browser 20.6 kB 20.8 kB +141 B (+0.7%)
    esm5 26.0 kB 26.1 kB +134 B (+0.5%)
    main 26.7 kB 26.8 kB +126 B (+0.5%)
    module 20.6 kB 20.8 kB +141 B (+0.7%)

  • @firebase/performance

    Type Base (352cc26) Head (bf11e91) Diff
    browser 28.4 kB 28.4 kB +40 B (+0.1%)
    esm5 30.1 kB 30.1 kB +37 B (+0.1%)
    main 30.5 kB 30.6 kB +41 B (+0.1%)
    module 28.4 kB 28.4 kB +40 B (+0.1%)

  • @firebase/remote-config

    Type Base (352cc26) Head (bf11e91) Diff
    browser 18.8 kB 18.8 kB +40 B (+0.2%)
    esm5 23.7 kB 23.7 kB +37 B (+0.2%)
    main 24.9 kB 24.9 kB +41 B (+0.2%)
    module 18.8 kB 18.8 kB +40 B (+0.2%)

  • @firebase/storage

    Type Base (352cc26) Head (bf11e91) Diff
    browser 52.1 kB 52.2 kB +43 B (+0.1%)
    esm5 58.3 kB 58.4 kB +40 B (+0.1%)
    main 53.6 kB 53.6 kB +51 B (+0.1%)
    module 52.1 kB 52.2 kB +43 B (+0.1%)

  • firebase

    Click to show 27 binary size changes.
    Type Base (352cc26) Head (bf11e91) Diff
    firebase-analytics-compat.js 25.9 kB 26.0 kB +94 B (+0.4%)
    firebase-analytics.js 107 kB 107 kB +294 B (+0.3%)
    firebase-app-compat.js 21.2 kB 21.3 kB +28 B (+0.1%)
    firebase-app.js 59.0 kB 59.2 kB +155 B (+0.3%)
    firebase-auth-compat.js 122 kB 122 kB +48 B (+0.0%)
    firebase-auth-cordova.js 459 kB 459 kB +146 B (+0.0%)
    firebase-auth-react-native.js 430 kB 430 kB +152 B (+0.0%)
    firebase-auth.js 409 kB 409 kB +149 B (+0.0%)
    firebase-compat.js 748 kB 749 kB +432 B (+0.1%)
    firebase-database-compat.js 168 kB 168 kB +63 B (+0.0%)
    firebase-database.js 603 kB 603 kB +149 B (+0.0%)
    firebase-firestore-compat.js 277 kB 277 kB +47 B (+0.0%)
    firebase-firestore-lite.js 244 kB 244 kB +135 B (+0.1%)
    firebase-firestore.js 762 kB 762 kB +154 B (+0.0%)
    firebase-functions-compat.js 7.90 kB 7.94 kB +47 B (+0.6%)
    firebase-functions.js 30.5 kB 30.6 kB +171 B (+0.6%)
    firebase-messaging-compat.js 37.8 kB 37.9 kB +140 B (+0.4%)
    firebase-messaging-sw.js 102 kB 102 kB +141 B (+0.1%)
    firebase-messaging.js 100 kB 101 kB +403 B (+0.4%)
    firebase-performance-compat.js 30.7 kB 30.8 kB +85 B (+0.3%)
    firebase-performance-standalone-compat.es2017.js 82.4 kB 82.5 kB +80 B (+0.1%)
    firebase-performance-standalone-compat.js 53.9 kB 54.0 kB +127 B (+0.2%)
    firebase-performance.js 118 kB 119 kB +298 B (+0.3%)
    firebase-remote-config-compat.js 27.5 kB 27.5 kB +83 B (+0.3%)
    firebase-remote-config.js 108 kB 109 kB +294 B (+0.3%)
    firebase-storage-compat.js 38.1 kB 38.2 kB +56 B (+0.1%)
    firebase-storage.js 140 kB 141 kB +265 B (+0.2%)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

Diffs between base commit (352cc26) and head commit (bf11e91) are too large (397,469 characters) to display.

Please check below links to see details from the original test log.

@Feiyang1 Feiyang1 merged commit 93795c7 into master Oct 12, 2021
@Feiyang1 Feiyang1 deleted the fei-pl-builds branch October 12, 2021 17:49
@google-oss-bot google-oss-bot mentioned this pull request Oct 12, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian left review comments

@hsubox76 hsubox76 hsubox76 approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@erikeldridge erikeldridge Awaiting requested review from erikeldridge

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@jposuna jposuna Awaiting requested review from jposuna

@jsdt jsdt Awaiting requested review from jsdt

@lisajian lisajian Awaiting requested review from lisajian

@sam-gc sam-gc Awaiting requested review from sam-gc

@yoyomyo yoyomyo Awaiting requested review from yoyomyo

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

@zwu52 zwu52 Awaiting requested review from zwu52

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@erikeldridge erikeldridge

@jposuna jposuna

@sam-gc sam-gc

@hsubox76 hsubox76

@schmidt-sebastian schmidt-sebastian

@zwu52 zwu52

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Feiyang1 @google-oss-bot @hsubox76 @schmidt-sebastian @erikeldridge @jposuna @sam-gc @zwu52