-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Vercel build #5830
Fix Vercel build #5830
Conversation
🦋 Changeset detectedLatest commit: b333c0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
// be able to use require() in esm. It only generates the nodejs version of the | ||
// polyfill, as opposed to the default polyfill which supports both browser and | ||
// nodejs. The browser support is unnecessary and doesn't work well with Jest. | ||
// See https://github.com/firebase/firebase-js-sdk/issues/5687 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-wrapped this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you check the link, the ternary was originally removed because the document check was coming up true for Jest which caused it to take the second option which broke Jest somehow, so I think this will break Jest again. I am not sure why Vercel is using the Node bundle in what seems to be a non-Node environment but I'll try to look into that right away.
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (1361656 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
This changes the manual replacement code to produce the exact output I got in 9.2:
Fixes #5823