RemoteDocumentCache APIs for Indexing #5988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8ce57c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
changed the title
Changeset File Check ✅
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (782,147 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
schmidt-sebastian
force-pushed
the
mrschmidt/rdc
branch
2 times, most recently
from
80573ca
to
5e1a25b
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/rdc
branch
from
5e1a25b
to
a74af48
Compare
wu-hui
reviewed
Mar 16, 2022
| return store.delete(key); | ||
| const path = documentKey.path.toArray(); | ||
| return store.delete([ | ||
| path.slice(0, path.length - 2), |
There was a problem hiding this comment.
There are quite some places using length - n to get what we want, maybe we should put all these in DocumentKey instead.
There was a problem hiding this comment.
I don't know if it will fit well in DocumentKey, as we don't really have good terminology for "path that leads up to the collection". I will figure out how to make this cleaner in place.
packages/firestore/src/local/indexeddb_remote_document_cache.ts
Outdated
Show resolved
Hide resolved
markarndt
reviewed
Mar 17, 2022
.changeset/seven-dolphins-breathe.md
Outdated
| "@firebase/firestore": patch | ||
| --- | ||
|
|
||
| The format of some of the IndexedDB data changed. This increases the performance of document lookups after an initial migration. If you do not want to migrate data, you can call `clearIndexedDbPersistence()` before invoking `enablIndexedDbPersistence()`. |
There was a problem hiding this comment.
Typo in line 5, needs another 'e', should be enableIndexedDbPersistence().
There was a problem hiding this comment.
@egilmorez ... Talked to sebastian, and these changes are internal-only, no user-breaking effects. Thanks for adding me to the review.
@schmidt-sebastian ... Please feel free to include me in Firestore PRs, all platforms, especially the PRs that touch public-facing reference docs. Thanks!
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the schema of the Remote Document Cache to rewrite the primary keys. The keys are now:
[ [prefix path ], collection group, read time, document ]
This allows for efficient scanning of indexed and non-indexed queries using
getAll(). The PR also addsgetDocumentsFromCollectionGroup, which means that all functionality required by Indexing is now available.TODO: