Do not invoke the App Check token listener for the same token string. #5993

ehsannas · 2022-02-10T20:32:31Z

No description provided.

changeset-bot · 2022-02-10T20:32:34Z

🦋 Changeset detected

Latest commit: 19d5c9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2022-02-10T20:52:07Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (3fe2c4a) Merge (1aa9044) Diff
browser 233 kB 233 kB +372 B (+0.2%)
esm5 290 kB 291 kB +376 B (+0.1%)
main 462 kB 463 kB +626 B (+0.1%)
module 233 kB 233 kB +372 B (+0.2%)
react-native 233 kB 233 kB +372 B (+0.2%)

`bundle`

Type	Base (`3fe2c4a`)	Merge (1aa9044)	Diff
firestore (Persistence)	234 kB	234 kB	+373 B (+0.2%)
firestore (Query Cursors)	190 kB	190 kB	+181 B (+0.1%)
firestore (Query)	191 kB	191 kB	+181 B (+0.1%)
firestore (Read data once)	179 kB	179 kB	+181 B (+0.1%)
firestore (Realtime updates)	181 kB	182 kB	+181 B (+0.1%)
firestore (Transaction)	164 kB	164 kB	+178 B (+0.1%)
firestore (Write data)	163 kB	163 kB	+178 B (+0.1%)

firebase
Type Base (3fe2c4a) Merge (1aa9044) Diff
firebase-compat.js 757 kB 758 kB +367 B (+0.0%)
firebase-firestore-compat.js 285 kB 285 kB +367 B (+0.1%)
firebase-firestore.js 783 kB 784 kB +842 B (+0.1%)

Test Logs

Base (3fe2c4a): https://github.com/firebase/firebase-js-sdk/actions/runs/1825595923
Merge (1aa9044): https://github.com/firebase/firebase-js-sdk/actions/runs/1831396956

https://storage.googleapis.com/firebase-sdk-metric-reports/vf7ZsbIVJb.html

google-oss-bot · 2022-02-10T21:06:58Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- AbstractUserDataWriter
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 23.4 kB 23.6 kB +177 B (+0.8%)
  size-with-ext-deps 72.0 kB 72.2 kB +178 B (+0.2%)
- Bytes
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 17.3 kB 17.5 kB +177 B (+1.0%)
  size-with-ext-deps 65.8 kB 65.9 kB +178 B (+0.3%)
- CACHE_SIZE_UNLIMITED
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.7 kB +178 B (+0.3%)
- CollectionReference
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 19.4 kB 19.6 kB +177 B (+0.9%)
  size-with-ext-deps 67.9 kB 68.1 kB +178 B (+0.3%)
- DocumentReference
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 19.4 kB 19.6 kB +177 B (+0.9%)
  size-with-ext-deps 67.9 kB 68.1 kB +178 B (+0.3%)
- DocumentSnapshot
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 22.9 kB 23.1 kB +177 B (+0.8%)
  size-with-ext-deps 71.4 kB 71.6 kB +178 B (+0.2%)
- FieldPath
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 18.7 kB 18.9 kB +177 B (+0.9%)
  size-with-ext-deps 67.2 kB 67.4 kB +178 B (+0.3%)
- FieldValue
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.7 kB +178 B (+0.3%)
- Firestore
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.6 kB +178 B (+0.3%)
- FirestoreError
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.6 kB +178 B (+0.3%)
- GeoPoint
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.6 kB 16.7 kB +177 B (+1.1%)
  size-with-ext-deps 65.1 kB 65.2 kB +178 B (+0.3%)
- LoadBundleTask
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.9 kB 17.0 kB +177 B (+1.1%)
  size-with-ext-deps 65.3 kB 65.5 kB +178 B (+0.3%)
- Query
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.1 kB 16.3 kB +177 B (+1.1%)
  size-with-ext-deps 64.6 kB 64.8 kB +178 B (+0.3%)
- QueryConstraint
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.7 kB +178 B (+0.3%)
- QueryDocumentSnapshot
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 22.9 kB 23.1 kB +177 B (+0.8%)
  size-with-ext-deps 71.4 kB 71.6 kB +178 B (+0.2%)
- QuerySnapshot
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 24.8 kB 25.0 kB +177 B (+0.7%)
  size-with-ext-deps 73.3 kB 73.5 kB +178 B (+0.2%)
- SnapshotMetadata
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.2 kB 16.3 kB +177 B (+1.1%)
  size-with-ext-deps 64.6 kB 64.8 kB +178 B (+0.3%)
- Timestamp
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 17.2 kB 17.4 kB +177 B (+1.0%)
  size-with-ext-deps 65.7 kB 65.8 kB +178 B (+0.3%)
- Transaction
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 42.0 kB 42.1 kB +177 B (+0.4%)
  size-with-ext-deps 90.6 kB 90.8 kB +178 B (+0.2%)
- WriteBatch
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 38.8 kB 38.9 kB +177 B (+0.5%)
  size-with-ext-deps 87.4 kB 87.6 kB +178 B (+0.2%)
- _DatabaseId
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.6 kB +178 B (+0.3%)
- _DocumentKey
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 25.1 kB 25.3 kB +177 B (+0.7%)
  size-with-ext-deps 73.6 kB 73.8 kB +178 B (+0.2%)
- _EmptyAppCheckTokenProvider
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.1 kB 16.3 kB +177 B (+1.1%)
  size-with-ext-deps 64.6 kB 64.8 kB +178 B (+0.3%)
- _EmptyAuthCredentialsProvider
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.7 kB +178 B (+0.3%)
- _FieldPath
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 18.4 kB 18.6 kB +177 B (+1.0%)
  size-with-ext-deps 66.9 kB 67.1 kB +178 B (+0.3%)
- _cast
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.8 kB 16.9 kB +177 B (+1.1%)
  size-with-ext-deps 65.2 kB 65.4 kB +178 B (+0.3%)
- _debugAssert
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.7 kB +178 B (+0.3%)
- _isBase64Available
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.7 kB +178 B (+0.3%)
- _logWarn
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.1 kB 16.3 kB +177 B (+1.1%)
  size-with-ext-deps 64.6 kB 64.7 kB +178 B (+0.3%)
- _setIndexConfiguration
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 23.9 kB 24.1 kB +177 B (+0.7%)
  size-with-ext-deps 72.4 kB 72.6 kB +178 B (+0.2%)
- _validateIsNotUsedTogether
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.7 kB +178 B (+0.3%)
- addDoc
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 106 kB 106 kB +177 B (+0.2%)
  size-with-ext-deps 156 kB 156 kB +178 B (+0.1%)
- arrayRemove
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 28.2 kB 28.4 kB +177 B (+0.6%)
  size-with-ext-deps 76.8 kB 77.0 kB +178 B (+0.2%)
- arrayUnion
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 28.2 kB 28.4 kB +177 B (+0.6%)
  size-with-ext-deps 76.8 kB 77.0 kB +178 B (+0.2%)
- clearIndexedDbPersistence
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 24.2 kB 24.6 kB +368 B (+1.5%)
  size-with-ext-deps 73.0 kB 73.3 kB +370 B (+0.5%)
- collection
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 20.1 kB 20.3 kB +177 B (+0.9%)
  size-with-ext-deps 68.7 kB 68.9 kB +178 B (+0.3%)
- collectionGroup
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 19.3 kB 19.5 kB +177 B (+0.9%)
  size-with-ext-deps 67.8 kB 68.0 kB +178 B (+0.3%)
- connectFirestoreEmulator
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 17.8 kB 18.0 kB +177 B (+1.0%)
  size-with-ext-deps 70.0 kB 70.2 kB +178 B (+0.3%)
- deleteDoc
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 97.3 kB 97.5 kB +177 B (+0.2%)
  size-with-ext-deps 147 kB 147 kB +178 B (+0.1%)
- deleteField
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.4 kB 16.6 kB +177 B (+1.1%)
  size-with-ext-deps 64.9 kB 65.0 kB +178 B (+0.3%)
- disableNetwork
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 86.0 kB 86.2 kB +177 B (+0.2%)
  size-with-ext-deps 136 kB 136 kB +178 B (+0.1%)
- doc
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 20.2 kB 20.4 kB +177 B (+0.9%)
  size-with-ext-deps 68.8 kB 68.9 kB +178 B (+0.3%)
- documentId
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 18.7 kB 18.9 kB +177 B (+0.9%)
  size-with-ext-deps 67.2 kB 67.4 kB +178 B (+0.3%)
- enableIndexedDbPersistence
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 146 kB 146 kB +369 B (+0.3%)
  size-with-ext-deps 196 kB 196 kB +370 B (+0.2%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 177 kB 178 kB +372 B (+0.2%)
  size-with-ext-deps 227 kB 228 kB +373 B (+0.2%)
- enableNetwork
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 86.0 kB 86.1 kB +177 B (+0.2%)
  size-with-ext-deps 136 kB 136 kB +178 B (+0.1%)
- endAt
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 34.1 kB 34.3 kB +177 B (+0.5%)
  size-with-ext-deps 82.7 kB 82.9 kB +178 B (+0.2%)
- endBefore
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 34.2 kB 34.3 kB +177 B (+0.5%)
  size-with-ext-deps 82.7 kB 82.9 kB +178 B (+0.2%)
- ensureFirestoreConfigured
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.1 kB 16.3 kB +177 B (+1.1%)
  size-with-ext-deps 64.6 kB 64.8 kB +178 B (+0.3%)
- executeWrite
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 96.4 kB 96.6 kB +177 B (+0.2%)
  size-with-ext-deps 146 kB 146 kB +178 B (+0.1%)
- getDoc
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 122 kB 122 kB +180 B (+0.1%)
  size-with-ext-deps 172 kB 172 kB +181 B (+0.1%)
- getDocFromCache
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 79.1 kB 79.3 kB +177 B (+0.2%)
  size-with-ext-deps 128 kB 128 kB +178 B (+0.1%)
- getDocFromServer
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 122 kB 122 kB +180 B (+0.1%)
  size-with-ext-deps 172 kB 172 kB +181 B (+0.1%)
- getDocs
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 124 kB 124 kB +180 B (+0.1%)
  size-with-ext-deps 174 kB 174 kB +181 B (+0.1%)
- getDocsFromCache
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 86.3 kB 86.5 kB +177 B (+0.2%)
  size-with-ext-deps 135 kB 135 kB +178 B (+0.1%)
- getDocsFromServer
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 124 kB 124 kB +180 B (+0.1%)
  size-with-ext-deps 174 kB 174 kB +181 B (+0.1%)
- getFirestore
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.1 kB 16.3 kB +177 B (+1.1%)
  size-with-ext-deps 64.8 kB 64.9 kB +178 B (+0.3%)
- increment
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.8 kB 17.0 kB +177 B (+1.1%)
  size-with-ext-deps 65.3 kB 65.5 kB +178 B (+0.3%)
- initializeFirestore
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.6 kB 16.8 kB +177 B (+1.1%)
  size-with-ext-deps 65.5 kB 65.7 kB +178 B (+0.3%)
- limit
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.8 kB 17.0 kB +177 B (+1.1%)
  size-with-ext-deps 65.3 kB 65.5 kB +178 B (+0.3%)
- limitToLast
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.9 kB 17.0 kB +177 B (+1.0%)
  size-with-ext-deps 65.4 kB 65.5 kB +178 B (+0.3%)
- loadBundle
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 94.8 kB 94.9 kB +177 B (+0.2%)
  size-with-ext-deps 145 kB 145 kB +178 B (+0.1%)
- namedQuery
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 72.6 kB 72.8 kB +177 B (+0.2%)
  size-with-ext-deps 121 kB 121 kB +178 B (+0.1%)
- onSnapshot
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 124 kB 125 kB +180 B (+0.1%)
  size-with-ext-deps 174 kB 174 kB +181 B (+0.1%)
- onSnapshotsInSync
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 114 kB 114 kB +180 B (+0.2%)
  size-with-ext-deps 164 kB 164 kB +181 B (+0.1%)
- orderBy
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 21.2 kB 21.3 kB +177 B (+0.8%)
  size-with-ext-deps 69.7 kB 69.9 kB +178 B (+0.3%)
- query
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.7 kB +178 B (+0.3%)
- queryEqual
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 25.6 kB 25.8 kB +177 B (+0.7%)
  size-with-ext-deps 74.1 kB 74.3 kB +178 B (+0.2%)
- refEqual
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 19.6 kB 19.8 kB +177 B (+0.9%)
  size-with-ext-deps 68.2 kB 68.3 kB +178 B (+0.3%)
- runTransaction
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 107 kB 107 kB +177 B (+0.2%)
  size-with-ext-deps 157 kB 157 kB +178 B (+0.1%)
- serverTimestamp
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.3 kB 16.5 kB +177 B (+1.1%)
  size-with-ext-deps 64.8 kB 65.0 kB +178 B (+0.3%)
- setDoc
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 105 kB 106 kB +177 B (+0.2%)
  size-with-ext-deps 155 kB 155 kB +178 B (+0.1%)
- setLogLevel
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.0 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.5 kB 64.7 kB +178 B (+0.3%)
- snapshotEqual
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 32.2 kB 32.4 kB +177 B (+0.5%)
  size-with-ext-deps 80.8 kB 81.0 kB +178 B (+0.2%)
- startAfter
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 34.2 kB 34.3 kB +177 B (+0.5%)
  size-with-ext-deps 82.7 kB 82.9 kB +178 B (+0.2%)
- startAt
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 34.2 kB 34.3 kB +177 B (+0.5%)
  size-with-ext-deps 82.7 kB 82.9 kB +178 B (+0.2%)
- terminate
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 16.1 kB 16.2 kB +177 B (+1.1%)
  size-with-ext-deps 64.7 kB 64.9 kB +178 B (+0.3%)
- updateDoc
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 106 kB 106 kB +177 B (+0.2%)
  size-with-ext-deps 156 kB 156 kB +178 B (+0.1%)
- waitForPendingWrites
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 86.4 kB 86.6 kB +177 B (+0.2%)
  size-with-ext-deps 136 kB 136 kB +178 B (+0.1%)
- where
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 40.2 kB 40.4 kB +177 B (+0.4%)
  size-with-ext-deps 88.8 kB 89.0 kB +178 B (+0.2%)
- writeBatch
  Size
  Type Base (3fe2c4a) Merge (1aa9044) Diff
  size 108 kB 108 kB +177 B (+0.2%)
  size-with-ext-deps 158 kB 158 kB +178 B (+0.1%)

Test Logs

Base (3fe2c4a): https://github.com/firebase/firebase-js-sdk/actions/runs/1825595923
Merge (1aa9044): https://github.com/firebase/firebase-js-sdk/actions/runs/1831396956

https://storage.googleapis.com/firebase-sdk-metric-reports/NYo1o42YxF.html

packages/firestore/src/api/credentials.ts

schmidt-sebastian · 2022-02-10T22:17:52Z

Please add changelog as well

Do not invoke the App Check token listener for the same token string.

eee339c

Fix formatting.

e2d84b0

ehsannas requested a review from schmidt-sebastian February 10, 2022 21:25

ehsannas assigned schmidt-sebastian Feb 10, 2022

schmidt-sebastian reviewed Feb 10, 2022

View reviewed changes

packages/firestore/src/api/credentials.ts Outdated Show resolved Hide resolved

packages/firestore/src/api/credentials.ts Outdated Show resolved Hide resolved

packages/firestore/src/api/credentials.ts Outdated Show resolved Hide resolved

schmidt-sebastian assigned ehsannas and unassigned schmidt-sebastian Feb 10, 2022

ehsannas added 2 commits February 11, 2022 11:41

Address comments.

9e126fb

Create gold-hounds-begin.md

5d81764

ehsannas requested a review from egilmorez as a code owner February 11, 2022 18:16

ehsannas assigned schmidt-sebastian and unassigned ehsannas Feb 11, 2022

ehsannas requested a review from schmidt-sebastian February 11, 2022 18:18

schmidt-sebastian assigned ehsannas and unassigned schmidt-sebastian Feb 11, 2022

Use fewer bytes for log messages.

19d5c9c

ehsannas assigned schmidt-sebastian and unassigned ehsannas Feb 11, 2022

schmidt-sebastian approved these changes Feb 11, 2022

View reviewed changes

schmidt-sebastian assigned ehsannas and unassigned schmidt-sebastian Feb 11, 2022

ehsannas merged commit bb8f37c into master Feb 12, 2022

ehsannas deleted the ehsann/appcheck-token-listener branch February 12, 2022 00:28

google-oss-bot mentioned this pull request Feb 16, 2022

Version Packages #6014

Merged

firebase locked and limited conversation to collaborators Mar 14, 2022

Do not invoke the App Check token listener for the same token string. #5993

Do not invoke the App Check token listener for the same token string. #5993

Conversation

ehsannas commented Feb 10, 2022

changeset-bot bot commented Feb 10, 2022 • edited Loading

🦋 Changeset detected

google-oss-bot commented Feb 10, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/firestore

bundle

firebase

Test Logs

google-oss-bot commented Feb 10, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/firestore

AbstractUserDataWriter

Bytes

CACHE_SIZE_UNLIMITED

CollectionReference

DocumentReference

DocumentSnapshot

FieldPath

FieldValue

Firestore

FirestoreError

GeoPoint

LoadBundleTask

Query

QueryConstraint

QueryDocumentSnapshot

QuerySnapshot

SnapshotMetadata

Timestamp

Transaction

WriteBatch

_DatabaseId

_DocumentKey

_EmptyAppCheckTokenProvider

_EmptyAuthCredentialsProvider

_FieldPath

_cast

_debugAssert

_isBase64Available

_logWarn

_setIndexConfiguration

_validateIsNotUsedTogether

addDoc

arrayRemove

arrayUnion

clearIndexedDbPersistence

collection

collectionGroup

connectFirestoreEmulator

deleteDoc

deleteField

disableNetwork

doc

documentId

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

endAt

endBefore

ensureFirestoreConfigured

executeWrite

getDoc

getDocFromCache

getDocFromServer

getDocs

getDocsFromCache

getDocsFromServer

getFirestore

increment

initializeFirestore

limit

limitToLast

loadBundle

namedQuery

changeset-bot bot commented Feb 10, 2022 •

edited

Loading

google-oss-bot commented Feb 10, 2022 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`bundle`

`firebase`

google-oss-bot commented Feb 10, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`AbstractUserDataWriter`

`Bytes`

`CACHE_SIZE_UNLIMITED`

`CollectionReference`

`DocumentReference`

`DocumentSnapshot`

`FieldPath`

`FieldValue`

`Firestore`

`FirestoreError`

`GeoPoint`

`LoadBundleTask`

`Query`

`QueryConstraint`

`QueryDocumentSnapshot`

`QuerySnapshot`

`SnapshotMetadata`

`Timestamp`

`Transaction`

`WriteBatch`

`_DatabaseId`

`_DocumentKey`

`_EmptyAppCheckTokenProvider`

`_EmptyAuthCredentialsProvider`

`_FieldPath`

`_cast`

`_debugAssert`

`_isBase64Available`

`_logWarn`

`_setIndexConfiguration`

`_validateIsNotUsedTogether`

`addDoc`

`arrayRemove`

`arrayUnion`

`clearIndexedDbPersistence`

`collection`

`collectionGroup`

`connectFirestoreEmulator`

`deleteDoc`

`deleteField`

`disableNetwork`

`doc`

`documentId`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`endAt`

`endBefore`

`ensureFirestoreConfigured`

`executeWrite`

`getDoc`

`getDocFromCache`

`getDocFromServer`

`getDocs`

`getDocsFromCache`

`getDocsFromServer`

`getFirestore`

`increment`

`initializeFirestore`

`limit`

`limitToLast`

`loadBundle`

`namedQuery`

`onSnapshot`

`onSnapshotsInSync`

`orderBy`

`query`

`queryEqual`

`refEqual`

`runTransaction`

`serverTimestamp`