Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in GtagConfigParams #6350

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fix typo in GtagConfigParams #6350

merged 1 commit into from
Jun 13, 2022

Conversation

dwyfrequency
Copy link
Contributor

@dwyfrequency dwyfrequency commented Jun 10, 2022 •
edited
Loading

Fix Typo in GtagConfigParams #6349

@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2022

⚠️ No Changeset found

Latest commit: 782d93a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dwyfrequency dwyfrequency marked this pull request as ready for review June 10, 2022 18:15
@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (790b08b) and merge commit (cc4113c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zBrLHjYknt.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (790b08b) and merge commit (cc4113c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mHv2GFWRXI.html

@dwyfrequency dwyfrequency merged commit ebc17e2 into master Jun 13, 2022
@dwyfrequency dwyfrequency deleted the updateAnalyticsType branch June 13, 2022 17:47
This was referenced Jun 13, 2022
Closed
Closed
dwyfrequency added a commit that referenced this pull request Jun 13, 2022
@dwyfrequency
Add Changeset for PR: 'Fix typo in GtagConfigParams #6350'
a9f912d
@dwyfrequency dwyfrequency mentioned this pull request Jun 13, 2022
Merged
dwyfrequency added a commit that referenced this pull request Jun 13, 2022
@dwyfrequency
Add Changeset for PR: 'Fix typo in GtagConfigParams #6350' (#6357)
835f1d4
@firebase firebase locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@allspain allspain Awaiting requested review from allspain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwyfrequency @google-oss-bot @hsubox76