Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix firestore/lite paths #6418

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Fix firestore/lite paths #6418

merged 2 commits into from
Jul 7, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jul 7, 2022 •
edited
Loading

Fix incorrect Node ESM exports paths for firestore/lite. They should match https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/lite/package.json

Made a mistake in #6321

Fixes #6414

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: ac9822c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 requested a review from egilmorez as a code owner July 7, 2022 17:31
dwyfrequency
dwyfrequency approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 7, 2022 •
edited
Loading

Size Report 1

Affected Products

  • bundle

    TypeBase (c187446)Merge (fbf686d)Diff
    firestore-lite (Query Cursors)210 kB67.9 kB-142 kB (-67.7%)
    firestore-lite (Query)210 kB71.1 kB-139 kB (-66.2%)
    firestore-lite (Read data once)200 kB55.5 kB-144 kB (-72.2%)
    firestore-lite (Transaction)184 kB80.1 kB-103 kB (-56.4%)
    firestore-lite (Write data)183 kB65.3 kB-118 kB (-64.4%)

  • firebase

    TypeBase (c187446)Merge (fbf686d)Diff
    firebase-firestore-lite.js845 kB267 kB-578 kB (-68.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qG2u9K3pbk.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 7, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (c187446) and merge commit (fbf686d).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KwZZTp7zUx.html

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Jul 7, 2022
@hsubox76 hsubox76 merged commit ad773fa into master Jul 7, 2022
@hsubox76 hsubox76 deleted the ch-firestore-pkg branch July 7, 2022 18:40
This was referenced Jul 7, 2022
Merged
Merged
@MarkDuckworth MarkDuckworth mentioned this pull request Jul 29, 2022
Closed
@firebase firebase locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees
No one assigned
Labels
doc-changes PRs that affect docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package.json exports should include "browser" for @firebase/firestore
3 participants
@hsubox76 @google-oss-bot @dwyfrequency