Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format comment containing process.env #6874

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Format comment containing process.env #6874

merged 2 commits into from
Dec 21, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Dec 9, 2022

Scramble "process.env" in a comment because some compiler or combination of build tools seems to choke on it.

Fixes #6838

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: e5f66bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@firebase/util Patch
@firebase/analytics-compat Patch
@firebase/analytics Patch
@firebase/app-check-compat Patch
@firebase/app-check Patch
@firebase/app-compat Patch
@firebase/app Patch
@firebase/auth-compat Patch
@firebase/auth Patch
@firebase/component Patch
@firebase/database-compat Patch
@firebase/database-types Patch
@firebase/database Patch
firebase Patch
@firebase/firestore-compat Patch
@firebase/firestore Patch
@firebase/functions-compat Patch
@firebase/functions Patch
@firebase/installations-compat Patch
@firebase/installations Patch
@firebase/messaging-compat Patch
@firebase/messaging Patch
@firebase/performance-compat Patch
@firebase/performance Patch
@firebase/remote-config-compat Patch
@firebase/remote-config Patch
@firebase/storage-compat Patch
@firebase/storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@hsubox76 hsubox76 marked this pull request as ready for review December 9, 2022 18:21
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 9, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase

    TypeBase (41549bb)Merge (9ba450b)Diff
    firebase-app.js92.0 kB92.2 kB+185 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NtMGccdIHt.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 9, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (41549bb) and merge commit (9ba450b).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Jag9LPJhQQ.html

dwyfrequency
dwyfrequency approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit d4114a4 into master Dec 21, 2022
@hsubox76 hsubox76 deleted the ch-vite-comment branch December 21, 2022 18:33
@google-oss-bot google-oss-bot mentioned this pull request Jan 17, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React build crash using vite and react 18.2.0
3 participants
@hsubox76 @google-oss-bot @dwyfrequency