Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Await on the auth initialization promise in signIn/link/reauthenticateWithRedirect #6914

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Await on the auth initialization promise in signIn/link/reauthenticateWithRedirect #6914

merged 3 commits into from
Jan 6, 2023

Conversation

prameshj
Copy link
Contributor

@prameshj prameshj commented Dec 28, 2022 •
edited
Loading

Await on the initialization promise to ensure that the processing of a pending redirect result (as part of auth init) is done before triggering a new redirect.

Fixes #6827

@changeset-bot
Copy link

changeset-bot bot commented Dec 28, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 98dd2eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 28, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (cd92522)Merge (49e761a)Diff
    browser156 kB157 kB+136 B (+0.1%)
    cordova184 kB184 kB+199 B (+0.1%)
    esm5205 kB205 kB+199 B (+0.1%)
    module156 kB157 kB+136 B (+0.1%)

  • @firebase/auth/cordova

    TypeBase (cd92522)Merge (49e761a)Diff
    browser184 kB184 kB+199 B (+0.1%)
    module184 kB184 kB+199 B (+0.1%)

  • @firebase/auth/internal

    TypeBase (cd92522)Merge (49e761a)Diff
    browser167 kB167 kB+136 B (+0.1%)
    esm5218 kB218 kB+199 B (+0.1%)
    module167 kB167 kB+136 B (+0.1%)

  • bundle

    TypeBase (cd92522)Merge (49e761a)Diff
    auth (GoogleRedirect)91.3 kB91.4 kB+31 B (+0.0%)

  • firebase

    TypeBase (cd92522)Merge (49e761a)Diff
    firebase-auth-compat.js126 kB126 kB+103 B (+0.1%)
    firebase-auth-cordova.js138 kB138 kB+166 B (+0.1%)
    firebase-auth.js117 kB117 kB+103 B (+0.1%)
    firebase-compat.js746 kB746 kB+103 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oienLJ1shv.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 28, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • linkWithRedirect

      Size

      TypeBase (cd92522)Merge (49e761a)Diff
      size37.8 kB37.9 kB+36 B (+0.1%)
      size-with-ext-deps58.5 kB58.5 kB+36 B (+0.1%)

    • reauthenticateWithRedirect

      Size

      TypeBase (cd92522)Merge (49e761a)Diff
      size37.6 kB37.6 kB+36 B (+0.1%)
      size-with-ext-deps58.2 kB58.2 kB+36 B (+0.1%)

    • signInWithRedirect

      Size

      TypeBase (cd92522)Merge (49e761a)Diff
      size37.3 kB37.3 kB+31 B (+0.1%)
      size-with-ext-deps57.9 kB57.9 kB+31 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NPW7TMmI3g.html

@prameshj prameshj force-pushed the redirect-race2 branch 2 times, most recently from 4949a7b to d7f1921 Compare January 4, 2023 08:14
@prameshj prameshj marked this pull request as ready for review January 4, 2023 17:52
@prameshj
Copy link
Contributor Author

prameshj commented Jan 4, 2023

/assign @sam-gc @renkelvin

sam-gc
sam-gc approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert yarn.lock

@prameshj prameshj merged commit 50b8191 into master Jan 6, 2023
@prameshj prameshj deleted the redirect-race2 branch January 6, 2023 23:12
This was referenced Jan 9, 2023
Open
Open
@google-oss-bot google-oss-bot mentioned this pull request Jan 17, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@lisajian lisajian Awaiting requested review from lisajian

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@prameshj @google-oss-bot @sam-gc