Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OR queries - relaxing in restrictions #7024

Merged
merged 6 commits into from
Feb 23, 2023
Merged

OR queries - relaxing in restrictions #7024

merged 6 commits into from
Feb 23, 2023

Conversation

MarkDuckworth
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 7adf26c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore-compat
@firebase/firestore
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MarkDuckworth
Copy link
Contributor Author

Cherry picked from #6757

@MarkDuckworth MarkDuckworth mentioned this pull request Feb 9, 2023
Closed
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 9, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (9874614)Merge (050953b)Diff
    browser156 kB156 kB+12 B (+0.0%)
    cordova184 kB184 kB+14 B (+0.0%)
    esm5205 kB205 kB+14 B (+0.0%)
    main148 kB148 kB+14 B (+0.0%)
    module156 kB156 kB+12 B (+0.0%)
    react-native168 kB168 kB+14 B (+0.0%)

  • @firebase/auth/cordova

    TypeBase (9874614)Merge (050953b)Diff
    browser184 kB184 kB+14 B (+0.0%)
    module184 kB184 kB+14 B (+0.0%)

  • @firebase/auth/internal

    TypeBase (9874614)Merge (050953b)Diff
    browser167 kB167 kB+12 B (+0.0%)
    esm5218 kB218 kB+14 B (+0.0%)
    main184 kB184 kB+14 B (+0.0%)
    module167 kB167 kB+12 B (+0.0%)

  • @firebase/auth/react-native

    TypeBase (9874614)Merge (050953b)Diff
    browser168 kB168 kB+14 B (+0.0%)
    module168 kB168 kB+14 B (+0.0%)

  • @firebase/firestore

    TypeBase (9874614)Merge (050953b)Diff
    browser273 kB274 kB+1.08 kB (+0.4%)
    esm5339 kB341 kB+1.09 kB (+0.3%)
    main546 kB548 kB+2.53 kB (+0.5%)
    module273 kB274 kB+1.08 kB (+0.4%)
    react-native273 kB274 kB+1.10 kB (+0.4%)

  • @firebase/firestore-lite

    TypeBase (9874614)Merge (050953b)Diff
    browser86.2 kB87.3 kB+1.08 kB (+1.3%)
    esm5104 kB105 kB+1.08 kB (+1.0%)
    main147 kB149 kB+2.32 kB (+1.6%)
    module86.2 kB87.3 kB+1.08 kB (+1.3%)
    react-native86.4 kB87.5 kB+1.10 kB (+1.3%)

  • @firebase/util

    TypeBase (9874614)Merge (050953b)Diff
    browser22.9 kB23.1 kB+159 B (+0.7%)
    esm524.4 kB24.7 kB+315 B (+1.3%)
    main30.0 kB30.4 kB+443 B (+1.5%)
    module22.9 kB23.1 kB+159 B (+0.7%)

  • bundle

    43 size changes

    TypeBase (9874614)Merge (050953b)Diff
    analytics (logEvent)43.0 kB43.1 kB+93 B (+0.2%)
    app-check (CustomProvider)36.1 kB36.2 kB+93 B (+0.3%)
    app-check (ReCaptchaEnterpriseProvider)38.4 kB38.5 kB+95 B (+0.2%)
    app-check (ReCaptchaV3Provider)38.4 kB38.5 kB+95 B (+0.2%)
    auth (Anonymous)67.4 kB67.5 kB+107 B (+0.2%)
    auth (EmailAndPassword)71.5 kB71.6 kB+107 B (+0.1%)
    auth (GoogleFBTwitterGitHubPopup)93.9 kB94.0 kB+106 B (+0.1%)
    auth (GooglePopup)91.1 kB91.2 kB+107 B (+0.1%)
    auth (GoogleRedirect)91.4 kB91.5 kB+107 B (+0.1%)
    auth (Phone)77.6 kB77.7 kB+107 B (+0.1%)
    database (Append to a list of data)148 kB148 kB+93 B (+0.1%)
    database (Filtering data)147 kB147 kB+93 B (+0.1%)
    database (Listen for child events)163 kB164 kB+93 B (+0.1%)
    database (Listen for value events + Detach listeners)163 kB164 kB+93 B (+0.1%)
    database (Listen for value events)163 kB163 kB+93 B (+0.1%)
    database (Read data once)163 kB163 kB+93 B (+0.1%)
    database (Save data as transactions)165 kB165 kB+93 B (+0.1%)
    database (Sort data)149 kB149 kB+93 B (+0.1%)
    database (Write data)147 kB147 kB+93 B (+0.1%)
    firestore (Persistence)281 kB281 kB+288 B (+0.1%)
    firestore (Query Cursors)220 kB220 kB-36 B (-0.0%)
    firestore (Query)218 kB217 kB-36 B (-0.0%)
    firestore (Read data once)205 kB205 kB+288 B (+0.1%)
    firestore (Realtime updates)207 kB207 kB+288 B (+0.1%)
    firestore (Transaction)188 kB188 kB+288 B (+0.2%)
    firestore (Write data)188 kB188 kB+288 B (+0.2%)
    firestore-lite (Query Cursors)81.3 kB81.2 kB-16 B (-0.0%)
    firestore-lite (Query)77.4 kB77.4 kB-16 B (-0.0%)
    firestore-lite (Read data once)59.4 kB59.7 kB+291 B (+0.5%)
    firestore-lite (Transaction)84.0 kB84.3 kB+293 B (+0.3%)
    firestore-lite (Write data)68.9 kB69.2 kB+291 B (+0.4%)
    functions (call)30.9 kB31.0 kB+100 B (+0.3%)
    messaging (send + receive)46.4 kB46.5 kB+95 B (+0.2%)
    performance (trace)50.8 kB50.9 kB+95 B (+0.2%)
    remote-config (getAndFetch)45.4 kB45.4 kB+93 B (+0.2%)
    storage (getBytes)41.1 kB41.2 kB+93 B (+0.2%)
    storage (getDownloadURL)43.2 kB43.3 kB+93 B (+0.2%)
    storage (getMetadata)42.7 kB42.8 kB+93 B (+0.2%)
    storage (list + listAll)42.1 kB42.2 kB+93 B (+0.2%)
    storage (updateMetadata)42.9 kB43.0 kB+93 B (+0.2%)
    storage (uploadBytes)48.0 kB48.1 kB+93 B (+0.2%)
    storage (uploadBytesResumable)58.0 kB58.1 kB+93 B (+0.2%)
    storage (uploadString)48.2 kB48.3 kB+93 B (+0.2%)

  • firebase

    19 size changes

    TypeBase (9874614)Merge (050953b)Diff
    firebase-app-check-compat.js22.6 kB22.7 kB+101 B (+0.4%)
    firebase-app-check.js21.4 kB21.5 kB+104 B (+0.5%)
    firebase-app-compat.js28.8 kB28.9 kB+99 B (+0.3%)
    firebase-app.js92.8 kB93.1 kB+243 B (+0.3%)
    firebase-auth-compat.js126 kB126 kB+113 B (+0.1%)
    firebase-auth-cordova.js138 kB138 kB+108 B (+0.1%)
    firebase-auth-react-native.js150 kB150 kB+138 B (+0.1%)
    firebase-auth.js117 kB117 kB+113 B (+0.1%)
    firebase-compat.js747 kB747 kB-15 B (-0.0%)
    firebase-database-compat.js166 kB166 kB+105 B (+0.1%)
    firebase-database.js154 kB154 kB+100 B (+0.1%)
    firebase-firestore-compat.js321 kB321 kB-29 B (-0.0%)
    firebase-firestore-lite.js92.9 kB94.0 kB+1.18 kB (+1.3%)
    firebase-firestore.js321 kB323 kB+1.18 kB (+0.4%)
    firebase-functions.js10.9 kB11.0 kB+91 B (+0.8%)
    firebase-performance-standalone-compat.es2017.js89.9 kB90.0 kB+106 B (+0.1%)
    firebase-performance-standalone-compat.js67.0 kB67.2 kB+140 B (+0.2%)
    firebase-storage-compat.js41.2 kB41.3 kB+101 B (+0.2%)
    firebase-storage.js40.2 kB40.3 kB+99 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DxckyxG9cc.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 9, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (916,907 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GJLnIWvrDZ.html

@ehsannas ehsannas assigned MarkDuckworth and unassigned ehsannas Feb 23, 2023
@MarkDuckworth MarkDuckworth merged commit 36558bd into master Feb 23, 2023
@MarkDuckworth MarkDuckworth deleted the markduckworth/relaxing-in-restrictions branch February 23, 2023 15:19
@google-oss-bot google-oss-bot mentioned this pull request Mar 1, 2023
Merged
renkelvin pushed a commit that referenced this pull request Mar 2, 2023
@MarkDuckworth
OR queries - relaxing in restrictions (#7024)
15a3be0 
Relaxing query validations performed by the Firestore SDK package
@firebase firebase locked and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@MarkDuckworth MarkDuckworth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkDuckworth @google-oss-bot @ehsannas