-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore: Add ability to configure long polling timeout #7176
Conversation
🦋 Changeset detectedLatest commit: 3bd125d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (542,285 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
…HttpRequestTimeoutSeconds WIP
…ateLongPollingOptions()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tom was right! ;-P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a changeset?
Done. Thanks for pointing that out. |
This changeset was created by #7176, but its wording neglected to update `idleHttpRequestTimeoutSeconds` to `experimentalLongPollingOptions.timeoutSeconds`. This commit fixes the wording to specify the correct property.
Add a new setting for Firestore:
experimentalLongPollingOptions.timeoutSeconds
. This new option can be used to configure the SDK’s underlying network transport (WebChannel) when long-polling is used, such as whenexperimentalAutoDetectLongPolling
orexperimentalForceLongPolling
is set totrue
.For convenience, here is the documentation for the new
experimentalLongPollingOptions.timeoutSeconds
property, copied from this PR's code:Below is an example that changes the long-polling "hanging get" timeout from the default (30 seconds) to 25 seconds:
Googlers see b/266868871
Fixes: #6987