Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sum avg #7502

Merged
merged 14 commits into from
Oct 10, 2023
Merged

sum avg #7502

merged 14 commits into from
Oct 10, 2023

Conversation

MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented Jul 28, 2023 •
edited
Loading

Adds support for sum and average aggregate queries. See go/firestore-sum-avg-online-api (internal only).

@MarkDuckworth MarkDuckworth requested review from a team as code owners July 28, 2023 17:29
@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b15c529

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Minor
firebase Minor
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MarkDuckworth MarkDuckworth requested a review from a team as a code owner July 28, 2023 20:30
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 28, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (cbfd14c)Merge (09fd705)Diff
    browser374 kB374 kB+40 B (+0.0%)
    esm5359 kB359 kB+40 B (+0.0%)
    main575 kB575 kB-6 B (-0.0%)
    module374 kB374 kB+40 B (+0.0%)
    react-native374 kB374 kB+40 B (+0.0%)

  • @firebase/firestore-lite

    TypeBase (cbfd14c)Merge (09fd705)Diff
    browser109 kB109 kB+42 B (+0.0%)
    esm5106 kB106 kB+42 B (+0.0%)
    main150 kB150 kB-6 B (-0.0%)
    module109 kB109 kB+42 B (+0.0%)
    react-native109 kB109 kB+42 B (+0.0%)

  • firebase

    TypeBase (cbfd14c)Merge (09fd705)Diff
    firebase-firestore-lite.js116 kB116 kB+42 B (+0.0%)
    firebase-firestore.js434 kB434 kB+40 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eD6Ni3U77t.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 31, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • AggregateField

      Size

      TypeBase (cbfd14c)Merge (09fd705)Diff
      size17.8 kB17.8 kB-1 B (-0.0%)
      size-with-ext-deps87.4 kB87.4 kB-1 B (-0.0%)

    • aggregateFieldEqual

      Size

      TypeBase (cbfd14c)Merge (09fd705)Diff
      size18.1 kB18.1 kB-3 B (-0.0%)
      size-with-ext-deps87.7 kB87.7 kB-3 B (-0.0%)

    • average

      Size

      TypeBase (cbfd14c)Merge (09fd705)Diff
      size21.4 kB21.4 kB-1 B (-0.0%)
      size-with-ext-deps91.1 kB91.1 kB-1 B (-0.0%)

    • count

      Size

      TypeBase (cbfd14c)Merge (09fd705)Diff
      size17.9 kB17.9 kB-1 B (-0.0%)
      size-with-ext-deps87.5 kB87.5 kB-1 B (-0.0%)

    • getAggregateFromServer

      Size

      TypeBase (cbfd14c)Merge (09fd705)Diff
      size109 kB109 kB+43 B (+0.0%)
      size-with-ext-deps180 kB180 kB+43 B (+0.0%)

    • getCountFromServer

      Size

      TypeBase (cbfd14c)Merge (09fd705)Diff
      size110 kB110 kB+42 B (+0.0%)
      size-with-ext-deps180 kB180 kB+42 B (+0.0%)

    • sum

      Size

      TypeBase (cbfd14c)Merge (09fd705)Diff
      size21.4 kB21.4 kB-1 B (-0.0%)
      size-with-ext-deps91.1 kB91.1 kB-1 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0hGy1hAGJS.html

hsubox76
hsubox76 reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a description in the PR? You can link to the API proposal or design doc and just say "(internal link)" after it.

.changeset/beige-oranges-eat.md Show resolved Hide resolved
hsubox76
hsubox76 reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks like there's some test failures directly related to this change.

@MarkDuckworth MarkDuckworth merged commit 02e2518 into master Oct 10, 2023
37 of 39 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/sum-avg-release branch October 10, 2023 18:11
@google-oss-bot google-oss-bot mentioned this pull request Oct 10, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas left review comments

@hsubox76 hsubox76 hsubox76 approved these changes

@markarndt markarndt markarndt approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

Assignees

@ehsannas ehsannas

@hsubox76 hsubox76

@markarndt markarndt

@wu-hui wu-hui

Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MarkDuckworth @google-oss-bot @ehsannas @hsubox76 @markarndt @wu-hui