Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update proto loader #7520

Merged
merged 4 commits into from
Aug 8, 2023
Merged

fix: Update proto loader #7520

merged 4 commits into from
Aug 8, 2023

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Aug 2, 2023 •
edited
Loading

Issue: #7484

@tom-andersen tom-andersen requested review from a team as code owners August 2, 2023 20:34
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b674c65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tom-andersen tom-andersen requested a review from a team as a code owner August 2, 2023 20:54
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 2, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (e037eee)Merge (7f659a6)Diff
    browser171 kB177 kB+5.97 kB (+3.5%)
    cordova198 kB206 kB+7.21 kB (+3.6%)
    esm5223 kB231 kB+7.21 kB (+3.2%)
    main168 kB175 kB+7.41 kB (+4.4%)
    module171 kB177 kB+5.97 kB (+3.5%)
    react-native182 kB189 kB+7.44 kB (+4.1%)

  • @firebase/auth/cordova

    TypeBase (e037eee)Merge (7f659a6)Diff
    browser198 kB206 kB+7.21 kB (+3.6%)
    module198 kB206 kB+7.21 kB (+3.6%)

  • @firebase/auth/internal

    TypeBase (e037eee)Merge (7f659a6)Diff
    browser182 kB188 kB+5.97 kB (+3.3%)
    esm5237 kB244 kB+7.21 kB (+3.0%)
    main204 kB211 kB+7.45 kB (+3.7%)
    module182 kB188 kB+5.97 kB (+3.3%)

  • @firebase/firestore

    TypeBase (e037eee)Merge (7f659a6)Diff
    browser370 kB371 kB+243 B (+0.1%)
    esm5356 kB356 kB+86 B (+0.0%)
    main569 kB569 kB+455 B (+0.1%)
    module370 kB371 kB+243 B (+0.1%)
    react-native371 kB371 kB+243 B (+0.1%)

  • @firebase/firestore-lite

    TypeBase (e037eee)Merge (7f659a6)Diff
    browser110 kB110 kB+203 B (+0.2%)
    esm5107 kB107 kB+86 B (+0.1%)
    main151 kB152 kB+415 B (+0.3%)
    module110 kB110 kB+203 B (+0.2%)
    react-native110 kB110 kB+203 B (+0.2%)

  • bundle

    18 size changes

    TypeBase (e037eee)Merge (7f659a6)Diff
    auth (Anonymous)71.2 kB72.6 kB+1.39 kB (+1.9%)
    auth (EmailAndPassword)76.2 kB79.9 kB+3.73 kB (+4.9%)
    auth (GoogleFBTwitterGitHubPopup)97.5 kB99.2 kB+1.77 kB (+1.8%)
    auth (GooglePopup)94.7 kB96.5 kB+1.77 kB (+1.9%)
    auth (GoogleRedirect)95.0 kB96.7 kB+1.77 kB (+1.9%)
    auth (Phone)81.1 kB82.9 kB+1.77 kB (+2.2%)
    firestore (Persistence)301 kB301 kB+25 B (+0.0%)
    firestore (Query Cursors)239 kB239 kB+25 B (+0.0%)
    firestore (Query)236 kB236 kB+25 B (+0.0%)
    firestore (Read data once)224 kB224 kB+25 B (+0.0%)
    firestore (Realtime updates)226 kB226 kB+25 B (+0.0%)
    firestore (Transaction)203 kB203 kB+25 B (+0.0%)
    firestore (Write data)203 kB203 kB+25 B (+0.0%)
    firestore-lite (Query Cursors)83.1 kB83.1 kB+28 B (+0.0%)
    firestore-lite (Query)79.2 kB79.3 kB+28 B (+0.0%)
    firestore-lite (Read data once)61.3 kB61.3 kB+15 B (+0.0%)
    firestore-lite (Transaction)86.1 kB86.1 kB+15 B (+0.0%)
    firestore-lite (Write data)70.8 kB70.9 kB+15 B (+0.0%)

  • firebase

    TypeBase (e037eee)Merge (7f659a6)Diff
    firebase-auth-compat.js132 kB136 kB+3.91 kB (+3.0%)
    firebase-auth-cordova.js169 kB174 kB+5.61 kB (+3.3%)
    firebase-auth.js142 kB147 kB+4.47 kB (+3.1%)
    firebase-compat.js774 kB778 kB+3.92 kB (+0.5%)
    firebase-firestore-compat.js340 kB340 kB+16 B (+0.0%)
    firebase-firestore-lite.js118 kB118 kB+203 B (+0.2%)
    firebase-firestore.js430 kB430 kB+243 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MWPTCDSxbO.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 2, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (825,421 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MXAoegOYMr.html

MarkDuckworth
MarkDuckworth approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With suggestions.

.changeset/heavy-dingos-obey.md Outdated
@@ -0,0 +1,5 @@
---
'@firebase/firestore': minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just be a patch. Otherwise LGTM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, should be a patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@tom-andersen tom-andersen mentioned this pull request Aug 2, 2023
Closed
@tom-andersen
Copy link
Contributor Author

@hsubox76 @dwyfrequency I need another approval in order to merge this one. Also, what is your opinion on whether this should be a minor or patch change?

hsubox76
hsubox76 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, agree with Mark it should be a patch.

@tom-andersen tom-andersen merged commit 43e402f into master Aug 8, 2023
25 of 26 checks passed
@tom-andersen tom-andersen deleted the tomandersen/updateProtoLoader branch August 8, 2023 15:01
@marcel-idana marcel-idana mentioned this pull request Aug 15, 2023
Closed
@google-oss-bot google-oss-bot mentioned this pull request Aug 15, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

Assignees

@dwyfrequency dwyfrequency

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tom-andersen @google-oss-bot @MarkDuckworth @hsubox76 @dwyfrequency