Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade webpack to v5 #7540

Merged
merged 7 commits into from
Aug 14, 2023
Merged

Upgrade webpack to v5 #7540

merged 7 commits into from
Aug 14, 2023

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Aug 8, 2023 •
edited
Loading

See internal doc (go/update-webpack-to-v5-firebase-js-sdk) for issues upgrading so far. This is needed to allow us to upgrade to Node 18+.

Continues #7374

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3791e52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 8, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (f73b24d) and merge commit (2452f98).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PFVwmTTt5f.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 8, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (f73b24d) and merge commit (2452f98).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ALDMTD3wGM.html

@hsubox76 hsubox76 marked this pull request as ready for review August 9, 2023 17:24
dwyfrequency
dwyfrequency approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 89fb9fd into master Aug 14, 2023
28 checks passed
@hsubox76 hsubox76 deleted the ch-webpack branch August 14, 2023 19:37
@firebase firebase locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renkelvin renkelvin renkelvin approved these changes

@dwyfrequency dwyfrequency dwyfrequency approved these changes

@lisajian lisajian Awaiting requested review from lisajian

@prameshj prameshj Awaiting requested review from prameshj

@sam-gc sam-gc Awaiting requested review from sam-gc

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsubox76 @google-oss-bot @renkelvin @dwyfrequency